Comments (4)
Hi, this has been the behaviour for quite some time now. Internally, the app works very, very differently than v2.3.5, and some operations do not retain metadata.
I'd be happy to review a PR to improve on this. Here are my thoughts on implementation.
It is probably fairly tricky to implement a generalized backend solution. The main problem is that a node may do anything with a given image and have any number of outputs, so it's probably not feasible to automatically copy metadata for all image operations. We'd need to have special handling to retrieve and save out metadata in every node.
A client solution for this one specific case is fairly straightforward. When building the ad-hoc upscaling graph, you could fetch the metadata for the image using RTK Query's imperative API and add it to the graph. Here's an example of using this API in the app (you'd be using the metadata endpoint instead of the DTO endpoint).
ESRGANInvocation
accepts an arbitrary dict for metadata - you can just put the retrieved metadata into the node:
You could optionally extend the retrieved image metadata, adding some upscaling related metadata to it. Keep in mind, though, that we do not support generating an image and upscaling it in one go, so you won't be able to "recall" the upscale.
from invokeai.
Didn't mean to suggest you specifically should implement the functionality - just some guidance for any contributor who might want to address the problem.
I'm curious, how do PS/Topaz compare to the upscaling we do? Ours isn't anything special, we just use the standard ESRGAN models widely used in open source apps. I would have guessed PS and Topaz give better results.
from invokeai.
Well, Topaz has a lot of control, which you'd expect for the price! I'm running it in trial mode for now - but I'd rather not fork over 200 bucks If I don't need to!
The 2024 version of Photoshop adds a bunch of generative stuff, but it's not close to a proper SD product...
from invokeai.
Thanks for the reply! Sadly, I'm too dumb to do anything at the level of custom API integration, but I appreciate the suggestion anyway..!
I've found that the latest builds of Photoshop and Topaz Photo both retain the meta, so I have a way of accomplishing the upscale in software; it's just a shame it's not something I can do from the Invoke UI now...
from invokeai.
Related Issues (20)
- [bug]: Certain SDXL controlnets fail conversion from safetensors with `KeyError: 'time_embed.0.weight'` HOT 1
- [bug]: Dimensions not properly preserved when switching models
- [enhancement]: Support SDXL Checkpoint VAEs HOT 5
- [enhancement]: Need better Toast text for loading model defaults
- [bug]: Weird Memory Error HOT 7
- [enhancement]: Update re-downloads Pytorch and others every time HOT 3
- [bug]: Older metadata not loading control layer
- [enhancement]: Add support empty LoRA Collect HOT 1
- [bug]: Unable to connect via LAN HOT 1
- [bug]: Import error
- [enhancement]: add straight line to brush canvas
- [enhancement]: Update documentation on Infill & Scaling
- Error encountered upon updating to version 4.2.4: XL models fail to execute. HOT 2
- [enhancement]: Inpainting node HOT 1
- [enhancement]: Stable Diffusion 3 HOT 2
- Error while trying to use regional guidance with IPAdapter
- [bug]: Stable diffusion 3 install Unauthorized error, but I have setup huggingface token and accepted sd3 licience HOT 2
- [bug]: Converting checkpoint to diffusers fails HOT 2
- [enhancement]: CFG++ HOT 6
- [bug]: Pasting paths with quotes into Model Manager gives an error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from invokeai.