Comments (6)
I have to share an interesting bug that caused an outage and took me a long time to figure out and is directly related to this issue:
Basically:
- NPM install on local files creates a symlink.
- Zipping removes the symlink.
- This can cause a bug with tools like
app-root-path
that uses_dirname
which can only happen in prod and is impossible to reproduce locally.
Exactly like what @jorgechen said.
from node-app-root-path.
The cause is using __dirname
to resolve the root path.
If a module is link
ed while being used locally in an app, the __dirname
in app-root-path
may not overlap with the app's path.
It makes using npm link
or yarn link
quite a hassle. Is there an easy way to fix this, or perhaps app-root-path
is simply not intended to be used in a NPM module?
from node-app-root-path.
Ran into this issue in an npm module I was developing. It worked great when actually npm/yarn installed, but not when linked. I ended up just creating a workaround option in my package for project root. However, it'd be great if there was a fallback if linked to somehow get the running project's root.
from node-app-root-path.
same issue here( Does not work when creating custom package for npm, it starts referring to the package project directory.
from node-app-root-path.
Same problem with pnpm workspaces.
Temporarily, I solved the issue by defining a APP_ROOT_PATH
environment var.
"scripts": {
"dev": "APP_ROOT_PATH=`pwd` my-dev-command"
}
from node-app-root-path.
Related Issues (20)
- node_modules isn't cool anymore, what to do HOT 12
- Webpack warning: Critical dependency: the request of a dependency is an expression HOT 4
- Support for yarn workspaces HOT 8
- npm package.json version != github repo version HOT 1
- New version broke webpack build with TypeORM HOT 3
- Auto including index.js HOT 1
- PNPM support?
- Latest NPM release failed (3.0.0) HOT 1
- What constituted the bump in major version? HOT 1
- Incompatible with Browserify HOT 1
- Mistenken added issue HOT 1
- Issues
- Issues
- Androidapk merge HOT 1
- wrongful access
- Google Cloud Functions reports incorrect path HOT 3
- Need Yarn 2 monorepo support
- Package throws an error when imported in an ES module installed globally on Ubuntu HOT 1
- ReferenceError: __dirname is not defined in ES module scope HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-app-root-path.