Giter Site home page Giter Site logo

Comments (6)

boellner avatar boellner commented on August 25, 2024 1

Option A

  • both results will be presented this way also and user can decide
  • cleaner separation and architecture, and I also do not not want to interfere with the knx adapter development
    I will upload my changes then for a review. Had a problem with a blocking license dialog.

from iobroker.discovery.

Apollon77 avatar Apollon77 commented on August 25, 2024

Normally you add a class here in this repo which is doing the discovery. For knx Adapter this is kind of there already https://github.com/ioBroker/ioBroker.discovery/blob/master/lib/adapters/knx.js ... so I see two options for openknx:

A) We add a second js file with pot your own discovery logic
B) We enhance the existing one and propose knx AND openknx and then user could decide

from iobroker.discovery.

boellner avatar boellner commented on August 25, 2024

#203

from iobroker.discovery.

boellner avatar boellner commented on August 25, 2024

please review the pull request to proceed here

from iobroker.discovery.

Apollon77 avatar Apollon77 commented on August 25, 2024

on my list

from iobroker.discovery.

boellner avatar boellner commented on August 25, 2024

very good

from iobroker.discovery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.