Compatibility issue with pytest 7.2: Package `py` is used but not listed as dependency

[abey79]

Compatibility issue with pytest 7.2: Package `py` is used but not listed as dependency

[alexprengere]

It would be great if a release could be made with that change 😉

[nicoddemus]

Just FYI, instead of depending on py, if the only dependency is the TerminalWriter, is to import it from from _pytest._io import TerminalWriter. While it is a private module, might be cleaner than depend on the deprecated py library.

[nicoddemus]

At first glance it looks good!

Given there were more changes than just an import, you might consider releasing a hotfix which just adds the py dependency, and after that make a new release which drops py completely (with the changes from c2e860f).

[ionelmc]

Just released 4.0.0.

[ionelmc]

@pyrito I don't own that repository not do I know much about conda packaging so that question would be best answered by opening an issue in that repository. I doubt they have notifications for releases so it's best to just ping the maintainers.

[ionelmc]

@nicoddemus what's the difference between those 2 TerminalWriters?

[nicoddemus]

None, we vendored py.io into pytest a long time ago, and nothing on them has changed since then. 👍

pytest-xdist just did the same thing (importing TerminalWriter from _pytest._io).

[ionelmc]

@nicoddemus alright I've changed to what you've suggested but it turns out there were other issues, not sure if I've fixed correctly, can you take a look at c2e860f ?

[pyrito]

Hi, thanks for the quick fix on the issue! When will pytest-benchmark make the new release?

[pyrito]

@ionelmc when will it be on conda-forge? Referring to this specifically: https://github.com/conda-forge/pytest-benchmark-feedstock