Giter Site home page Giter Site logo

Comments (4)

cmaart avatar cmaart commented on July 26, 2024

Verified, that the code fixes my issue as mentioned here: https://forum.ionicframework.com/t/having-a-custom-rollup-config-breaks-the-watcher/65343

from ionic-app-scripts.

adamdbradley avatar adamdbradley commented on July 26, 2024

Awesome, thanks for the PR and unit tests too!

from ionic-app-scripts.

cmaart avatar cmaart commented on July 26, 2024

@adamdbradley No problem. A publish would be good though :-)
Maybe this issue is related as well #42

from ionic-app-scripts.

cmaart avatar cmaart commented on July 26, 2024

Btw. having the fix and all is fine.. but codewise i'd go for immutable types. This wouldn't have happened if config classes for example are not mutable in the first place. Didn't want to do these changes in a PR now, just need a working version to keep on going with my project for now

from ionic-app-scripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.