Importers: DAGService should not be batched internally by default

[ipfs]

Importers: DAGService should not be batched internally by default

[schomatis]

Agreed, we're imposing the batch.

it would be the user of the importer responsibility to call Commit when the importer has returned, if a Batch dag service was used in the first place.

Could we expand the DagBuilderParams.New function (or create a new one) to allow to set (or not) the batch service? That way we could maintain the DagBuilderHelper responsibility of calling commit if the batch service was set in the first place (to avoid laying that burden on the user of the importers that would need to add the Commit line after every already existing Layout call). Would that work for you?

[hsanjuan]

@schomatis that works (hopefully the code can stay clean-ish).

Still, I do feel the batching or not batching should not be a responsability of this module. We could take the chance that this is only used in ipfs and cluster to simplify it. Adding the batch wrapping directly on go-ipfs when adding is by all means a very simple task and it's probably where it should be (in a explicit fashion). Your call!

[schomatis]

Yes, I kind of agree, when I was refactoring the balanced builder the close/commit logic felt kind of weird. It's fine by me if you want to take out the commit logic part (or ping me if you need help), cc'ing @Stebalien in case he wants to weigh in here.

[hsanjuan]

@Stebalien any feedback? @whyrusleeping (this might affect fc too)

[Stebalien]

I agree this is a higher-level concern. If a user passes a batch into the importer, the user is responsible for committing the batch.

This is probably left-over from when this was built-in to go-ipfs (and we didn't really care about other users).