Giter Site home page Giter Site logo

Comments (7)

minrk avatar minrk commented on August 21, 2024

Can you share code that reproduces the issue?

from traitlets.

pwm1234 avatar pwm1234 commented on August 21, 2024

The code below works differently in ipython (terminal) and ipython notebook. In crafting this example, I learned a little more about the problem, which I think I could avoid if I better understood how to make an Application subclass that worked properly (and identically) when instantiated from both an ipython terminal and ipython notebook. With a trivial example like this it seems silly. But with a real Application that is responsible for gluing together several complex Configurable objects it is not so obvious (to me at least). Here is a simple example that demonstrates my original problem:

from traitlets.config import Configurable, Application
from traitlets import Unicode, Int, Float, List

import sys

class MyClass(Configurable):
    str = Unicode(u'default string', config=True)
    an_int = Int(1, config=True)

    def __init__(self, log, **kwargs):
        super(MyClass, self).__init__(**kwargs)
        self._log = log

    def debug(self, msg):
        self._log.debug(msg)

    def info(self, msg):
        self._log.info(msg)

    def warn(self, msg):
        self._log.warn(msg)

    def error(self, msg):
        self._log.error(msg)

    def test_log(self):
        self.debug('dbg')
        self.info('info')
        self.warn('warn')
        self.error('error')

class MyApp(Application):
    a_float = Float(1.23, config=True)

    classes = List([
        MyClass,
    ])

    def __init__(self, **kwargs):
        super(MyApp, self).__init__(**kwargs)


def main(argv=None):
    cls = MyClass(MyApp.instance().log)
    cls.test_log()

def main2(argv=None):
    cls = MyClass(MyApp().log)
    cls.test_log()

print('calling main2')    
main2(['hello'])
print('works with ipython but not notebook')

print('using logger from host application instance')
MyClass(Application.instance().log).test_log()
print('works with ipython but not notebook')

print('using a.test.logger')
import logging
# could also reload and reconfigure, but do not need too
#reload(logging)
#logging.basicConfig(format='%(asctime)s %(levelname)s:%(message)s', level=logging.DEBUG, datefmt='%I:%M:%S')
mylogger = logging.getLogger('a.test.logger')
mylogger.setLevel(logging.INFO)
MyClass(mylogger).test_log()
print('works with both')


#if __name__ == "__main__":
#   main2(sys.argv)

from traitlets.

pwm1234 avatar pwm1234 commented on August 21, 2024

A better example is the one that ships with traitlets in traitlets/examples/myapp.py. Use the following from both an IPython terminal session and an IPython notebook. The terminal session generates log output while the notebook session does not.

import myapp
import sys
sys.argv = [sys.argv[0]]
sys.argv.append('--MyApp.log_level=DEBUG')
myapp.main()

The above code from terminal session generates

[MyApp] Config changed:
[MyApp] {'MyApp': {'log_level': u'DEBUG'}}
app.config:
{'MyApp': {'log_level': u'DEBUG'}}

and from the notebook session generates, where the [MyApp] log output is missing

app.config:
{'MyApp': {'log_level': u'DEBUG'}}

from traitlets.

rmorshea avatar rmorshea commented on August 21, 2024

I'm not quite sure what's going on with your situation, and I can't imagine it has anything to do with the version of the notebook you're using, but for me, the code you wrote above gives the appropriate output.

from traitlets.

pwm1234 avatar pwm1234 commented on August 21, 2024

For what it is worth

import IPython
IPython.__version__

outputs '4.0.1'

from traitlets.

rmorshea avatar rmorshea commented on August 21, 2024

I'm running off master, so 4.1.0-dev. Might be worth trying it out to see if that fixes anything.

from traitlets.

rkern avatar rkern commented on August 21, 2024

Possibly fixed by #233.

from traitlets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.