Interaction with prettify-symbols-mode

[iqbalansari]

Interaction with prettify-symbols-mode

[iqbalansari]

Hi,

I am glad you like the package.

Unfortunately AFAIK it might not be possible to integrate this with prettify-symbol-mode atleast not using the current mechanism, since prettify-symbols-mode uses the composition text property to render the desired keywords with symbols. As such emojify would not be able to search for the text to be displayed as emoji.

However this might be possible via a different mechanism (I am just thinking out aloud), emojify can search for the text which have composition text property set and if the value is an emoji, it can render the underlying text as image. Your thoughts?

[cpitclaudel]

This definitely sounds like a good idea!
Another option could be to parse the prettify-symbols table and remove the entries that emojify can handle, adding the instead to emojify's own tables.

[iqbalansari]

Hi @cpitclaudel,

I have implemented support for prettify-symbols-mode on a branch, would it be possible for you to give it a try before I push it to MELPA?

Thanks

[cpitclaudel]

Sure; do I just check that branch out?

[iqbalansari]

Yes that should do it

[cpitclaudel]

This isn't working for me; maybe I'm doing something wrong.

I have:

(setq prettify-symbols-alist '(("lambda" . 955)
 ("self" . 33258)
 ("yield" . 8674)
 ("return" . 8618)
 ("try" . 128561)
 ("except" . 9936)
 ("raise" . 128165)
 ("assert" . 10003)))

and I ran (emojify-set-emoji-style '(prettify-symbols ascii unicode github))

Typing an explicit 😱 in the source does yield an emoji, but typing try prettifies it to 😱, which does not get emojified.

[iqbalansari]

Sorry my bad, there is a typo in the README, the relevant style here is prettify-symbol not prettify-symbol*s*

[iqbalansari]

Hi, just wanted to let you know that I have merged this to master, it seemed to be working well with my limited testing. It should be available in the next MELPA build.

It is disabled by default, to enable it just do

(emojify-set-emoji-style '(prettify-symbol ascii unicode github))

And re-enable prettify-symbol-mode if it is already enabled. I will enable it by default once I get thumbs up from you 😄

Thanks

[iqbalansari]

Hi @cpitclaudel, you got a chance to try this again?

[cpitclaudel]

I did! Seems to work great :) I didn't have to re-enable prettify-symbols-mode; it worked out of the box.

Thanks!