Please add a prefix to test-helper.el to avoid conflicts with 68 other packages

[iqbalansari]

Please add a prefix to test-helper.el to avoid conflicts with 68 other packages

[tarsius]

I've been informed, that ert-runner automatically loads the test-helper.el file. So you should not rename that file. Instead please see this issue, where I suggest that the (provide 'test-helper) should be dropped instead. Please accept my apologize for opening these issues prematurely.

[iqbalansari]

Hi,

Thanks for the heads up, I appreciate your concerns. However none of these packages are distributed with the test files, so they should not cause problems for the user, am I missing something?

[tarsius]

I think so, yes. Not everyone uses Melpa to install packages. (I for one use git submodules and have even written an alternative package manager, borg to better deal with that.) "People not using Melpa" also includes those users who only temporarily use your package from the git repository because they want to contribute something to it. Those are the users who you really want to be able to run the tests.

[iqbalansari]

Makes sense, will make the change. Thanks for the hard work.