Comments (14)
Hi, thanks for the bug report. I think I have a solution for this. Just to properly debug this, what is the theme you are using, the effect is not noticeable in the themes I use (solarized).
from emacs-emojify.
I'm using monokai in the screen shot above. I just tried switching to the 'solarized-dark' and 'tango' themes, both of which seem to have the same issue.
from emacs-emojify.
Actually I meant the effect is not as pronounced as the screenshot above, I agree that it is present. Just pushed a possible fix, could you please try (when MELPA updates)?
from emacs-emojify.
The display is much improved and mostly fixed, but it seems like maybe only the fully transparent portions of the emojis are affected.
^notice the pixels closest to the emoji which appear to be anti-aliased against the darker background
from emacs-emojify.
I think that is a problem in the images themselves, I will try to fix this tonight
from emacs-emojify.
This seems to be an issue with images. The images bundled with emojify are resized (24px) versions of the ones from emoji-one
this was done to mitigate the inability to resize images on Emacsen compiled with no imagemagick support. I tried using original images from emoji-one
and they look better than the resized ones (though not perfect), have a look
The first emoji is rendered using the resized version bundled with emojify the second is rendered using the original image from emoji-one
.
I hope to solve this indirectly by implementing #4 (which I will get to soon) and then (using your idea of different image sets) allowing users to download unresized images if they prefer.
from emacs-emojify.
On an unrelated note, thanks a lot for all your inputs on different issues, much appreciated
from emacs-emojify.
Perhaps we can test for imagemagick support and create pixel-perfect renditions when it's available.
Thank you for putting your effort into creating a great emoji experience in Emacs. You're doing a great job with this package and it's my pleasure to support you.
from emacs-emojify.
Hi,
Just wanted to post an update on this. I initially came up with a specific solution that solved the problem only for emojis in regions that code is in feature/better-backgrounds
branch, a more general solution for the problem is in exp/aggressive-bg-face
branch which works for any background face. My only concern is efficiency of updating emoji backgrounds (which I am doing in a post-command-hook
), on my old laptop Intel Core i3 processor and 4 GB RAM it around 0.000660s - 0.001609s seconds to update backgrounds of visible emoji in the data/emoji.json file, which I think might be efficient enough. What do you think?
I will be testing it over the week for any bugs or performance issues, if all goes well I will merge this to master.
from emacs-emojify.
Hi @ryanprior,
Did you get a chance to test the branch? I personally haven't come across any regressions and plan to merge exp/aggressive-bg-face
tomorrow.
from emacs-emojify.
I haven't had the chance to test yet. Go ahead and merge, I'll report any bugs I find!
from emacs-emojify.
I have merged the branch to master, hopefully the issues you have mentioned should have been fixed. Could you please try it when MELPA builds and report back?
Thanks
from emacs-emojify.
Looks flawless with my brief testing just now. With this fix and hidpi icons coming with #4, Emacs will have the best-looking emoji rendering of any app on any platform. What an accomplishment!
from emacs-emojify.
Thanks for confirming! A lot for credit for this goes to you, I would have not got around to implementing this had you not pushed for it
I will leave this issue open for sometime before closing it.
from emacs-emojify.
Related Issues (20)
- Infinite loop where interactive but unable to answer HOT 2
- Loading a large number of user emoji can break emoji rendering Emacs wide HOT 1
- Is there a way to exclude individual emojis?
- Can I manually download emoji fonts and still make everything works? HOT 2
- cut and paste org heading with org-bullets + emojify
- Feature request: Replace ascii emoji with unicode in buffer HOT 1
- Example for predicate in emojify-completing-read doesn't work HOT 2
- Is it possible to use openmoji that I downloaded manually?
- Emoji is not displayed in mini buffer HOT 1
- Blurred emojis on HiDPI screen
- Org-mode agenda time label being incorrectly identified as emoji HOT 1
- Feature request: Support compound emojis (like the pride flag)
- How to use color emoji font (ttf) instead of png files? HOT 2
- (void-variable memavailable) HOT 1
- Convert unicode emojis to ascii
- 100% CPU load
- Twemoji-v13.1.0
- Do not replace org-mode literal strings
- filter emojis in emojify-insert-emoji by custom status
- Emojis render correctly in buffer, minibuffer, but not in menu with ivy-posframe enabled
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from emacs-emojify.