20190809_KEW_comments

[iqis]

20190809_KEW_comments

[iqis]

Code

• showing my ignorance: Why do we have to quote a mod in drop() but not in use()? (e.g., drop("my_test_mod") vs. use(my_test_mod)

  • Ideally both would take character strings. The user may supply bare symbol as argument, because use() attempts follow the convention set by require() and library(). The drop() function has no comparable counterparts, and thus follow the function it calls: detach()

• in the 'refer()' documentation or warnings (beyond default), it would be useful to let the user know that refer() will mask assignments from the previous module.
  e.g.,

  • This is a good idea. The Tidyverse is sporting a verbose style to help the interactive user, too. I'll think about this and balance it with the R tradition of keeping mouth shut when nothing goes wrong.

my_other_test_mod <- mod::module({
refer(my_test_mod)
a <- 1
b <- 2
})

• In regard to above comment, you might also consider an implementation tool that helps the user compare the contents of each module before a mask occurs. I am reminded of the option to compare versions within Microsoft. Would a function that compares the contents of two modules be feasible?
  • I think this would not be very necessary, as the user can simply do: ls(mod_b) %in% ls(mod_a) or something similar to get an idea for name conflict. The user is also expected to be familiar with the contents of either modules if he had created them.

[wendtke]

• showing my ignorance: Why do we have to quote a mod in drop() but not in use()? (e.g., drop("my_test_mod") vs. use(my_test_mod)

  • This is because use() attempts follow the convention set by require() and library().

Okay, that was my guess! Thanks!