Giter Site home page Giter Site logo

Comments (6)

bqminh avatar bqminh commented on August 11, 2024

tagging @thomaskf here for discussions.
That's interesting. What Lars and Thomas did, was not exactly about log-likelihoods but about accuracy. So they simulated a bunch of alignments and free-rates, and ask whether BFGS or EM most frequently obtained the the true rates back. And the answer was EM.
I remember that, I also did a bunch of empirical alignments, and observed that none of them always obtained higher likelihood than the other. Sometimes BFGS got higher likelihood, sometimes EM.
@roblanf 's suggestion is sensible. I believe Thomas put such code in IQ-TREE after our meeting. Thomas, can you pls test this data set?

from iqtree2.

roblanf avatar roblanf commented on August 11, 2024

@thomaskf if you can post the relevant commandline here, I can test it on this dataset (it's a GISAID dataset so hard to share).

from iqtree2.

roblanf avatar roblanf commented on August 11, 2024

Also I'm not totally convinced about simulating data and then asking whether we get the 'true' rates back. We only expect to get the 'true' rates if we have infinite species (well, infinite tree length really) and infinite sites.

E.g. if the number of species is limited, more and more sites will look like constant sites rather than sites from a 'true' low rate category. Because of these limitations, I tend to think that in ML software we should really consider the methods (within reason, of course!) that give us the best likelihood. If that disagrees with simulation conditions, it will often be because of some other limitation.

from iqtree2.

thomaskf avatar thomaskf commented on August 11, 2024

@roblanf sorry for the late reply. I agree with your point. I have updated the codes last Saturday so that in each iteration 1-BFGS->EM is performed, and the iteration will be repeated until the convergence is reached. I am uploading the codes soon so that you can have a test. Meanwhile, I still need a bit more time to finalize the paper with Allen and I will work at full speed on the project starting from next week. Apology for the delay and the inconvenience caused.

from iqtree2.

roblanf avatar roblanf commented on August 11, 2024

Hi @thomaskf, that sounds good. Just make sure that the three algorithms are available as different flags:

  1. one for EM only
  2. one for BFGS only
  3. one for EM/BFGS combined

from iqtree2.

bqminh avatar bqminh commented on August 11, 2024

@thomaskf : I don't think 1-BFGS->EM a good approach, because after doing BFGS, you will be in a local optimum. If you now start EM from that local optimum, I don't see how it help to escape it, except for moving a bit around it. It's better to have independent starting points, with/without different algorithms. Since this is quite a long time with no sensible solution, I recommend that we close this discussion, also because everyone is busy with other projects and we don't really have person to pursue it further, esp. in testing different approaches.

from iqtree2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.