Giter Site home page Giter Site logo

Comments (3)

iridakos avatar iridakos commented on May 23, 2024

@ikteru Thanks for the detailed feedback. I will check on it and with some help from contributors (since I don't use ZSH) we should proceed to the suggested changes.

from goto.

kasperschnack avatar kasperschnack commented on May 23, 2024

@iridakos

I believe it is mainly the case that .zshrc and .bashrc co-exists as bash is the default shell in many systems and zsh gets added. I think a possible workaround could be to change the if statement in the install script to check whether $SHELL == /bin/bash or $SHELL == /bin/zsh. This would also fix #55 as the cause of the issue is the same :)

from goto.

solisoares avatar solisoares commented on May 23, 2024

@kasperschnack

Thought that too, but turns out that the $SHELL variable points to the login shell of the current user, not the shell running for the current user.

In my Linux machine I use zsh as my normal shell but for sudo it is bash, and the install script must be run in sudo mode so $SHELL is always bash when I run the script.

We can parse /etc/passwd for the normal shell but i think it would break on Mac and Windows. What do you think @iridakos ?

from goto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.