Giter Site home page Giter Site logo

Comments (11)

iced avatar iced commented on July 22, 2024

Don't really think we need to do this. E.g. for ruby gems it'll be very messy (the only way will be to generate Gemfile and feed it to bundler, which can mess with user's environment).

from iron_worker_ruby_ng.

treeder avatar treeder commented on July 22, 2024

It could maybe just check if gem exists on machine and do gem install if doesn't. I run into this a lot and the only way to figure it out is to read the .worker file and install them manually anyways or keep doing upload and installing the gem it errors on (the more likely way when asking someone to try an example) until it works.

from iron_worker_ruby_ng.

romand avatar romand commented on July 22, 2024

% iron_worker install tst       
------> Detecting worker dependencies
        Found workerfile with path='tst.worker'
        Adding ruby gem dependency with name='pry' and version='>= 0'
        Detected ruby exec with path='tst.rb'
        Fixating gems dependencies
        Merging ruby gem with name='coderay' and version='1.0.7'
        Merging ruby gem with name='method_source' and version='0.8'
        Merging ruby gem with name='slop' and version='3.3.2'
        Merging ruby gem with name='pry' and version='0.9.10'
------> Installing gems
        coderay (1.0.7) installed
        method_source (0.8) installed
        slop (3.3.2) installed
        pry (0.9.10) installed

from iron_worker_ruby_ng.

romand avatar romand commented on July 22, 2024

@treeder looks good?
@iced any objections on implementation?

from iron_worker_ruby_ng.

treeder avatar treeder commented on July 22, 2024

Nice!

from iron_worker_ruby_ng.

romand avatar romand commented on July 22, 2024

f1a1d8e

  • fixes double gem install
  • gems from merge_gemfile are not installed now -- bug

from iron_worker_ruby_ng.

iced avatar iced commented on July 22, 2024

implemented long time ago

from iron_worker_ruby_ng.

romand avatar romand commented on July 22, 2024
  • it doesn't complain if worker file is missing
  • it doesn't install merge_gemfile gems

IMHO it is premature to close this

from iron_worker_ruby_ng.

iced avatar iced commented on July 22, 2024

We can't resolve gemfiles without gems installed. Send "thank you" letter to rubygems devs. Closing.

from iron_worker_ruby_ng.

treeder avatar treeder commented on July 22, 2024

Does it install gems from merged gemfile?

from iron_worker_ruby_ng.

romand avatar romand commented on July 22, 2024

not for me

~/iw
% cat tst.worker 
gemfile 'tst.gemfile'
exec 'test/hello.rb'
~/iw
% cat tst.gemfile
source "https://rubygems.org"

gem 'to_nil'
~/iw
% iron_worker install tst
------> Installing dependencies for code package with name='tst'
        Found workerfile with path='tst.worker'
        Adding ruby gems dependencies from default group of tst.gemfile
/home/romand/.rvm/gems/ruby-1.9.3-p194@iron_worker_ng/gems/iron_worker_ng-0.12.0/lib/iron_worker_ng/code/base.rb:75:in `eval': Could not find gem 'to_nil (>= 0) ruby' in the gems available on this machine. (Bundler::GemNotFound)

also it doesn't complain if worker file is missing

~/iw
% ruby -Ilib bin/iron_worker install kruplumpl
------> Installing dependencies for code package with name='kruplumpl'

from iron_worker_ruby_ng.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.