Comments (3)
Might be fixed by #817
@ross-u I reproduced the issue but inconsistently so I cannot be sure this is a definitive fix.
The reason state
results undefined could be because of the let
declaration that causes a TDZ on state
or also because the page.reload()
in the beforeEach()
directive in the test suite causes the sync call to be fired too soon, before the whole script I loaded. If this async
fix does not work maybe we could protect by waiting until state !== 'undefined'
Line 12 is:
in fact getPageState(
) is always called with await
, therefore it should return a promise explicitly
from lab-dom-pizza-builder.
This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from lab-dom-pizza-builder.
This pull request is closed. Thank you.
from lab-dom-pizza-builder.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lab-dom-pizza-builder.