Giter Site home page Giter Site logo

Comments (6)

Kaian avatar Kaian commented on May 22, 2024

Hi @ssinyagin !

Thanks for reporting :)

I was only considering 486 and 603 response codes as REJECTED, but I think all Client (4XX), Server (5XX) and Global (6XX) failures should be displayed as REJECTED too.

If a new INVITE request is sent after a failure, call status will be again in CALL SETUP, so dialog can change from REJECT to CALL SETUP after a failure response code.

For example:

INVITE -> CALL SETUP
404 Unauthorized -> REJECTED
ACK
INVITE -> CALL SETUP
100 Trying 
180 Ringing
200 OK -> IN CALL
ACK
BYE -> COMPLETED
ACK 

from sngrep.

ssinyagin avatar ssinyagin commented on May 22, 2024

yes, that one in my tests was a call without authentication. Actually 404 is a special and frequently-used case, so maybe a special display string is even better, like AUTHREQ

thanks for the great tool, by the way :)

from sngrep.

Kaian avatar Kaian commented on May 22, 2024

Actually this feature is inspired in wireshark VoIP Calls dialog, where only following states are considered:

CALL SETUP
RINGING
IN CALL
CANCELLED
COMPLETED
REJECTED
UNKNOWN

Creating more states will be nice for feedback, but some states will last only milliseconds.

In Authentication responses (404, 407,..), most probably a new INVITE request with authentication will be sent right away so AUTHREQ won't be shown to our human eyes.

Glad to know this tools helps!!

from sngrep.

ssinyagin avatar ssinyagin commented on May 22, 2024

I saw the link in freeswitch-user mailing list, and I posted it to G+ :)
actually in case of unsuccessful authentication, the corresponding status indication will be nice

from sngrep.

ssinyagin avatar ssinyagin commented on May 22, 2024

the fix worked fine, we can close this ticket

from sngrep.

Kaian avatar Kaian commented on May 22, 2024

Nice!

If while using sngrep you actually feel the need that the new state for Authentication is actually required, feel free to open a new issue :)

Thanks again!

from sngrep.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.