graceful-fs does not work properly with io.js

[isaacs]

graceful-fs does not work properly with io.js

[Fishrock123]

The aforementioned code linked to by electron originates in this commit: nodejs/node@e653080#diff-9a205ef7ee967ee32efee02e58b3482dR242

The technical problem is this: https://github.com/isaacs/node-graceful-fs/blob/master/fs.js#L8-L10

Using process.binding() (especially in this way) effectively voids the warranty. Perhaps there is some other way to wrap / patch fs?

If not, I think I've motioned before that I wouldn't mind this functionality being in core. See also, this twitter thread: https://twitter.com/isntitvacant/status/608708444539895809

[vkurchatkin]

node-graceful-fs relies on implementation details heavily. Either we should include it in core or rewrite it using public API only.

[bpasero]

+1 for making this part of io.js and/or the future node. The fact that this lib has to go deep into internals shows that it belongs into core. I would not even make it optional or through a flag. If I hit EMFILE, just retry for up to N times.

[Fishrock123]

See also: nodejs/node#1941

[Fishrock123]

+1 for making this part of io.js and/or the future node. The fact that this lib has to go deep into internals shows that it belongs into core.

Yes, I think you make a good point here. Stuff that can't be otherwise properly supported is what ought to be the primary candidates for core APIs.

[isaacs]

Fixed on v4