Comments (10)
Small update, the domain save fix has survived through multiple browsers restarts, full OS reboots, two full system update, running multiple instances of the same tab at once, etc. Seems pretty solid to me.
from auro.
@kawazoe exactly, you're right, i look at code now and remembered commented hostDeviceId
wasn't stable =)
i'll try to continue development on the week i think
from auro.
@kawazoe thank you!
To add extension locally, you should turn on developer mode in extensions, then click "Load unpacked" and select it from your disk
from auro.
@kawazoe its implemented already (https://github.com/ish-/AuRo/blob/main/extension/background.js#L28)
i think the problem is "privateness" of Brave browser, check it in Chrome
from auro.
@ish- I think I know what's going on. When I query the storage I get a bunch of values like this:
tab_137: "1c560f8a96130cfb42b802ff9dc75f30bffdcaddcb9e41c0dadb40e70b6329a6"
tab_2306: "1c560f8a96130cfb42b802ff9dc75f30bffdcaddcb9e41c0dadb40e70b6329a6"
After closing the PWA and reopening it again (not with ctrl+shift+T), I got yet a new id. My conclusion is that the tab.id
you're getting from chrome.tabs.query()
isn't stable, at least not in Brave.
EDIT: I also believe that those ids in Brave are sequential, meaning that a tab might end up with the wrong output device without the user intervention on subsequent sessions depending on the rights they have given to the extension.
from auro.
@kawazoe hello! i committed this feature here at first, maybe you would try it locally for some days and feedback :)
6a77c55
from auro.
Sure! Can you give me some info on how to package the code into the final extension? I assume I only have to zip the content of the extension
folder, correct?
from auro.
So far, it seems to be working flawlessly! I'll keep running the extension in dev mode for now. You can close the issue when you release the update so I know I can switch back to the official release. 😃
from auro.
@kawazoe oh, nice to hear it =) ill upload it over the next few days
thank you!
from auro.
from auro.
Related Issues (11)
- Question(s) HOT 2
- Update manifest for v3 spec HOT 12
- Can't set a custom ouput device on SoundCloud HOT 11
- This does not work on focusmate.com
- [suggestion] Add a link to a help page HOT 1
- Ui doesn't update HOT 5
- Doesn't work on stream-together.org
- What permissions are needed to get AuRo to work? HOT 3
- aplication does'nt play HOT 2
- can't run with https://soundcloud.com/ HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from auro.