Giter Site home page Giter Site logo

Comments (10)

kawazoe avatar kawazoe commented on August 28, 2024 2

Small update, the domain save fix has survived through multiple browsers restarts, full OS reboots, two full system update, running multiple instances of the same tab at once, etc. Seems pretty solid to me.

from auro.

ish- avatar ish- commented on August 28, 2024 1

@kawazoe exactly, you're right, i look at code now and remembered commented hostDeviceId wasn't stable =)
i'll try to continue development on the week i think

from auro.

ish- avatar ish- commented on August 28, 2024 1

@kawazoe thank you!
To add extension locally, you should turn on developer mode in extensions, then click "Load unpacked" and select it from your disk

from auro.

ish- avatar ish- commented on August 28, 2024

@kawazoe its implemented already (https://github.com/ish-/AuRo/blob/main/extension/background.js#L28)
i think the problem is "privateness" of Brave browser, check it in Chrome

from auro.

kawazoe avatar kawazoe commented on August 28, 2024

@ish- I think I know what's going on. When I query the storage I get a bunch of values like this:

tab_137: "1c560f8a96130cfb42b802ff9dc75f30bffdcaddcb9e41c0dadb40e70b6329a6"
tab_2306: "1c560f8a96130cfb42b802ff9dc75f30bffdcaddcb9e41c0dadb40e70b6329a6"

After closing the PWA and reopening it again (not with ctrl+shift+T), I got yet a new id. My conclusion is that the tab.id you're getting from chrome.tabs.query() isn't stable, at least not in Brave.

EDIT: I also believe that those ids in Brave are sequential, meaning that a tab might end up with the wrong output device without the user intervention on subsequent sessions depending on the rights they have given to the extension.

from auro.

ish- avatar ish- commented on August 28, 2024

@kawazoe hello! i committed this feature here at first, maybe you would try it locally for some days and feedback :)
6a77c55

from auro.

kawazoe avatar kawazoe commented on August 28, 2024

Sure! Can you give me some info on how to package the code into the final extension? I assume I only have to zip the content of the extension folder, correct?

from auro.

kawazoe avatar kawazoe commented on August 28, 2024

So far, it seems to be working flawlessly! I'll keep running the extension in dev mode for now. You can close the issue when you release the update so I know I can switch back to the official release. 😃

from auro.

ish- avatar ish- commented on August 28, 2024

@kawazoe oh, nice to hear it =) ill upload it over the next few days
thank you!

from auro.

ish- avatar ish- commented on August 28, 2024

6a77c55

from auro.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.