Giter Site home page Giter Site logo

Comments (4)

jcubic avatar jcubic commented on June 12, 2024

There were problems running test locally, but recently I run them and they were working fine. I need to check how I've run them. But note that those are lint error. I'm not sure why they show up locally and not in CI/CD.

from isomorphic-git.

jcubic avatar jcubic commented on June 12, 2024

Weird I've got this error:

Error: Cannot find module './.prettierrc.cjs' from '/home/kuba/projects/jcubic/isomorphic-git/TEST/node_modules/isomorphic-git'
Occurred while linting /home/kuba/projects/jcubic/isomorphic-git/TEST/node_modules/isomorphic-git/http/node/index.js:1
    at Function.sync (/home/kuba/projects/jcubic/isomorphic-git/node_modules/prettier/index.js:15946:13)
    at Object.transform (/home/kuba/projects/jcubic/isomorphic-git/node_modules/prettier/index.js:22820:36)
    at run (/home/kuba/projects/jcubic/isomorphic-git/node_modules/prettier/third-party.js:4583:30)
    at cacheWrapper (/home/kuba/projects/jcubic/isomorphic-git/node_modules/prettier/third-party.js:4358:16)
    at Explorer.searchFromDirectorySync (/home/kuba/projects/jcubic/isomorphic-git/node_modules/prettier/third-party.js:4587:16)
    at run (/home/kuba/projects/jcubic/isomorphic-git/node_modules/prettier/third-party.js:4580:25)
    at cacheWrapper (/home/kuba/projects/jcubic/isomorphic-git/node_modules/prettier/third-party.js:4358:16)
    at Explorer.searchFromDirectorySync (/home/kuba/projects/jcubic/isomorphic-git/node_modules/prettier/third-party.js:4587:16)
    at run (/home/kuba/projects/jcubic/isomorphic-git/node_modules/prettier/third-party.js:4580:25)
    at cacheWrapper (/home/kuba/projects/jcubic/isomorphic-git/node_modules/prettier/third-party.js:4358:16)
The script called "lint" which runs "eslint ." failed with exit code 2 https://github.com/sezna/nps/blob/master/other/ERRORS_AND_WARNINGS.md#failed-with-exit-code
The script called "test" which runs "nps lint && nps build && nps test.typecheck && nps test.setup && nps test.jest && nps test.karma && nps test.teardown" failed with exit code 2 https://github.com/sezna/nps/blob/master/other/ERRORS_AND_WARNINGS.md#failed-with-exit-code

But the tests are running fine:

export NODE_OPTIONS=--openssl-legacy-provider
npx nps build && npx nps test.typecheck && npx nps test.setup && npx nps test.jest && npx nps test.karma && npx nps test.teardown

from isomorphic-git.

seanpoulter avatar seanpoulter commented on June 12, 2024

I don't think the build/test will work on Node v10. I see an error using flatMap here:
a34579c#diff-8108a824db5615a9442788ac6a5ede7b30df99cd36f8ab4db1ffdf1d569429dcR156-R161

If we scroll over for Node v10, you'll see flatMap isn't supported.
https://node.green/#ES2019-features-Array-prototype--flat--flatMap-

from isomorphic-git.

jcubic avatar jcubic commented on June 12, 2024

We need to update the README and website with supported Node version. This is kind of silly that the README say it supports Node 10. It probably works because of bundled version (the build was not changed since Node 10 was supported).

from isomorphic-git.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.