Report the actual service name in zipkin

[bjartek]

Report the actual service name in zipkin

[rshriram]

It is certainly possible. Our choice of a generic service name was based on the fact that in kubernetes , pods are be late bound to services (pods are created first and then the service association is done) or a pod could be part of multiple services or a pod could have its service affiliations changed dynamically. As a data point, do any of the corner cases apply to your case (one pod being part of multiple services or a pod's service being changed dynamically from service A to service B) ? If they don't apply, then we have an easy way out for this. Please take a look at this discussion in istio-dev and feel free to weigh in. https://groups.google.com/forum/m/#!topic/istio-dev/6UWnwCAtHyA cc @smawson @frankbu @kyessenov @dcberg

…

-- ~shriram

[bjartek]

None of the edges cases apply to us. Pods are part of one service. We currently do not do blue/green deployment but if we where too i think we would create two services with their own set of pods and load balance either in istio or just in openshift routes.

What about the posibility to configure this? Everybody has different use cases :)

[rshriram]

That's what we are leaning towards. Btw, the way we do blue-green deployments does not involve creating multiple services. You can put all pods under the same service. As long as the two versions have different sets of labels (e.g. "app=foo,version=v1" and "app=foo,version=v2" are two deployments under service whose selectors are "app=foo"). You can now set routing rules such that you send 95% of traffic to label set "app=foo,version=v1" and the remaining 5% to label set "app=foo,version=v2". It's documented in request routing task.

On Mon, Jul 10, 2017 at 8:42 AM Bjarte S. Karlsen ***@***.***> wrote: None of the edges cases apply to us. Pods are part of one service. We currently do not do blue/green deployment but if we where too i think we would create two services with their own set of pods and load balance either in istio or just in openshift routes. What about the posibility to configure this? Everybody has different use cases :) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#45 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH0qd4Dd-ZaB3AwXF7qoeTWV_PPMftwjks5sMhxHgaJpZM4OSky5> .

-- ~shriram

[bjartek]

Interesting and from my perspective even better :)

[objectiser]

This has been fixed in istio/old_pilot_repo#1368. Once the next release is available, if you could confirm and then close this issue. Thanks.

[bjartek]

Sorry for the huge delay here. I will try to verify this now that we have time to look at istio again.

[bianpengyuan]

This is fixed by istio/istio#5931 and istio/istio#6219