Giter Site home page Giter Site logo

Comments (9)

geeknoid avatar geeknoid commented on July 20, 2024

Slight update:

istio.io/mixer/cmd/mixer/main.go
istio.io/mixer/cmd/mixerclient/main.go
istio.io/mixer/pkg/adapter/... (adapter support
istio.io/mixer/pkg/api/... (most of what's currently in mixer/server/*.go)
istio.io/mixer/​pkg/config/...
istio.io/mixer/pkg/attribute/...
istio.io/mixer/doc/...
istio.io/mixer/adapter/... (individual adapters)
istio.io/mixer/example/...

This structure provides high-level functional separation. We can have multiple commands for various utilities, we have room for examples & docs, and we have a flat set of adapters and flat set of support packages. This generally matches how k8s is organized.

Any counter proposals?

@mandarjog @douglas-reid

from old_mixer_repo.

mandarjog avatar mandarjog commented on July 20, 2024

yup, let's go for it.
pkg should have importable reusable packages.
LGTM.

from old_mixer_repo.

geeknoid avatar geeknoid commented on July 20, 2024

from old_mixer_repo.

douglas-reid avatar douglas-reid commented on July 20, 2024

one nit.

why not:

mixer/cmd/server
mixer/cmd/client

?

from old_mixer_repo.

geeknoid avatar geeknoid commented on July 20, 2024

Yeah /server and /client looks good.

On a related note, what should we call our binaries? "server" and "client" seems a tad generic and unhelpful to the casual observer. Maybe mixserver and mixclient?

from old_mixer_repo.

douglas-reid avatar douglas-reid commented on July 20, 2024

mixserver sgtm. is it worth using something shorter than client for the client? maybe mixcli or mixctl or or mixcmd or even mixc ?

from old_mixer_repo.

geeknoid avatar geeknoid commented on July 20, 2024

from old_mixer_repo.

douglas-reid avatar douglas-reid commented on July 20, 2024

What if we leave the dirs as server and client but have the go_binary rules named something like "mixs" and "mixc" or whatever? (the go build equivalent of the -o option)

from old_mixer_repo.

geeknoid avatar geeknoid commented on July 20, 2024

from old_mixer_repo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.