Giter Site home page Giter Site logo

Comments (4)

kyessenov avatar kyessenov commented on August 23, 2024

Deprecating labels in destination weight would be nice (although a bit verbose).
I think the code does check for this case, or least it's documented here: https://github.com/istio/api/blob/master/proxy/v1/config/route_rule.proto#L157

from pilot.

frankbu avatar frankbu commented on August 23, 2024

At one point during the design we had two different proto messages for the source and destination fields, because destinations don't use labels. We simplified to use IstioService for both and added the doc: "When used for a RouteRule destination, labels MUST be empty.".
https://istio.io/docs/reference/config/traffic-rules/routing-rules.html#istioservice

from pilot.

kyessenov avatar kyessenov commented on August 23, 2024

Issue moved to istio/istio #1361 via ZenHub

from pilot.

kyessenov avatar kyessenov commented on August 23, 2024

Issue moved to istio/istio #1362 via ZenHub

from pilot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.