Giter Site home page Giter Site logo

Comments (4)

itm4n avatar itm4n commented on July 22, 2024 1

Yup, we read the same doc! 😉
I think that PSv5.1 is now considered as the minimum PS version in the entire documentation.
But a Copy() seemed like a very basic operation that you would expect even in older versions.
So, I tested it by copying a random object in PSv2 and it worked! 🙂
I double checked on Windows Server 2008 R2 as well.

from privesccheck.

itm4n avatar itm4n commented on July 22, 2024

That's awesome! You are finding all the bugs in my code! 🙂

This one was easy to fix though. Here is what I did:

$ResultItem = $CurrentTask.PsObject.Copy()
$ResultItem | Add-Member -MemberType "NoteProperty" -Name "ModifiablePath" -Value $_.ModifiablePath
$ResultItem | Add-Member -MemberType "NoteProperty" -Name "IdentityReference" -Value $_.IdentityReference
$ResultItem | Add-Member -MemberType "NoteProperty" -Name "Permissions" -Value $_.Permissions
$ResultItem

Rather than modifying the source object, I create a copy of it and I add the relevant fields to the object's copy. I made sure that it is still PSv2 compatible because I haven't used this trick before.
In the other checks, I created a new object for each new result. I don't know why I didn't do that in these two checks.

Anyway, thanks a lot! 🙂

from privesccheck.

itm4n avatar itm4n commented on July 22, 2024

And, yeah the -Force would have been a quick fix but it could have some side effects that are difficult to foresee. So, I prefer to play safe here and simply make a copy of the object. Perhaps it's actually what -Force does under the hood... 🙄 I don't know.

from privesccheck.

SAERXCIT avatar SAERXCIT commented on July 22, 2024

Great, thanks for fixing!

I saw Copy() but did not want to implement it because its documentation page mentions it only applies to PSv5, but since you actually tried and it works, it means the MS doc is not complete (or I misunderstood something 🙃).

Closing the issue, cheers!

from privesccheck.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.