Comments (5)
Hi!
One would expect that ConvertTo-Xml
properly handles and escapes invalid characters, but it does not as it turns out...
PS C:\> [char]0x00 | ConvertTo-Xml
ConvertTo-Xml : '.', hexadecimal value 0x00, is an invalid character.
At line:1 char:15
+ [char]0x00 | ConvertTo-Xml
+ ~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (:) [ConvertTo-Xml], ArgumentException
+ FullyQualifiedErrorId : System.ArgumentException,Microsoft.PowerShell.Commands.ConvertToXmlCommand
PS C:\> [char]0x01 | ConvertTo-Xml
ConvertTo-Xml : '☺', hexadecimal value 0x01, is an invalid character.
At line:1 char:15
+ [char]0x01 | ConvertTo-Xml
+ ~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (:) [ConvertTo-Xml], ArgumentException
+ FullyQualifiedErrorId : System.ArgumentException,Microsoft.PowerShell.Commands.ConvertToXmlCommand
PS C:\> [char]0x02 | ConvertTo-Xml
ConvertTo-Xml : '☻', hexadecimal value 0x02, is an invalid character.
At line:1 char:15
+ [char]0x02 | ConvertTo-Xml
+ ~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (:) [ConvertTo-Xml], ArgumentException
+ FullyQualifiedErrorId : System.ArgumentException,Microsoft.PowerShell.Commands.ConvertToXmlCommand
PS C:\> [char]0x41 | ConvertTo-Xml
xml Objects
--- -------
version="1.0" encoding="utf-8" Objects
I'll have to add a function for sanitizing the output before exporting to XML.
from privesccheck.
Yep, fixed ! I let you the satisfaction of closing the issue :)
from privesccheck.
(also thx for the beautiful color, much better ! )
from privesccheck.
Before converting the result to XML, I now strip all the potentially invalid XML characters from the ResultRawString
member.
I found a very efficient way to do so on StackOverflow. 🙂
Could you test again in the same conditions and tell me if it's ok?
from privesccheck.
Thanks for the confirmation! 👍
from privesccheck.
Related Issues (20)
- Get-ModifiablePath false positive result processing deny only SID HOT 9
- Helper script detected by AMSI when building HOT 1
- Wifi Airstrike Attack (CVE-2021-28316) already mitigated Apr 13, 2021 HOT 2
- Cannot find process with ID for UDP Endpoints HOT 2
- Specified cast is not valid HOT 9
- Windows 11 detected as Windows 10 HOT 3
- Scheduled Task: Binary Exploitation no detection HOT 2
- Empty WinLogon credentials HOT 1
- Check for vulnerable WPAD configuration? HOT 2
- Report Improvement Suggestion HOT 2
- [Improvement] Check for vulnerable drivers HOT 1
- SERVICES > Unquoted Path not work as expected HOT 3
- Credential Guard HOT 3
- [Feature Request] Readd Compliance Field HOT 4
- Getting erros when trying to run it HOT 2
- Get-HotFixList misses updates HOT 2
- LapsV2 is not being checked? HOT 3
- Check SMB signing required HOT 5
- Service binary permissions false positive HOT 1
- List ASR rules HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from privesccheck.