Giter Site home page Giter Site logo

Comments (5)

itm4n avatar itm4n commented on July 22, 2024 1

Hi!

One would expect that ConvertTo-Xml properly handles and escapes invalid characters, but it does not as it turns out...

PS C:\> [char]0x00  | ConvertTo-Xml
ConvertTo-Xml : '.', hexadecimal value 0x00, is an invalid character.
At line:1 char:15
+ [char]0x00  | ConvertTo-Xml
+               ~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [ConvertTo-Xml], ArgumentException
    + FullyQualifiedErrorId : System.ArgumentException,Microsoft.PowerShell.Commands.ConvertToXmlCommand

PS C:\> [char]0x01  | ConvertTo-Xml
ConvertTo-Xml : '☺', hexadecimal value 0x01, is an invalid character.
At line:1 char:15
+ [char]0x01  | ConvertTo-Xml
+               ~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [ConvertTo-Xml], ArgumentException
    + FullyQualifiedErrorId : System.ArgumentException,Microsoft.PowerShell.Commands.ConvertToXmlCommand

PS C:\> [char]0x02  | ConvertTo-Xml
ConvertTo-Xml : '☻', hexadecimal value 0x02, is an invalid character.
At line:1 char:15
+ [char]0x02  | ConvertTo-Xml
+               ~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [ConvertTo-Xml], ArgumentException
    + FullyQualifiedErrorId : System.ArgumentException,Microsoft.PowerShell.Commands.ConvertToXmlCommand

PS C:\> [char]0x41  | ConvertTo-Xml

xml                            Objects
---                            -------
version="1.0" encoding="utf-8" Objects

I'll have to add a function for sanitizing the output before exporting to XML.

from privesccheck.

mpgn avatar mpgn commented on July 22, 2024 1

Yep, fixed ! I let you the satisfaction of closing the issue :)

from privesccheck.

mpgn avatar mpgn commented on July 22, 2024 1

(also thx for the beautiful color, much better ! )

from privesccheck.

itm4n avatar itm4n commented on July 22, 2024

Before converting the result to XML, I now strip all the potentially invalid XML characters from the ResultRawString member.
I found a very efficient way to do so on StackOverflow. 🙂

Could you test again in the same conditions and tell me if it's ok?

from privesccheck.

itm4n avatar itm4n commented on July 22, 2024

Thanks for the confirmation! 👍

from privesccheck.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.