Giter Site home page Giter Site logo

Comments (9)

syeopite avatar syeopite commented on June 29, 2024

That... Is a major AGPL violation. The AGPL licence requires all distribution (network included) to disclose their source code and clearly state changes.

Until you provide those information, I'm afraid we can't add your instance onto the official list.

from documentation.

TechnicalSuwako avatar TechnicalSuwako commented on June 29, 2024

@syeopite
https://git.076.ne.jp/TechnicalSuwako/invidious-mod/-/commit/a87e94b9816ff15688706a957de1a19e45538fe6

from documentation.

SamantazFox avatar SamantazFox commented on June 29, 2024

@syeopite
https://git.076.ne.jp/TechnicalSuwako/invidious-mod/-/commit/a87e94b9816ff15688706a957de1a19e45538fe6

Just for your information: most of the changes you made to the source code may (and are going to) break invidious. I won't detail here why, but be aware that, in general, the gl parameter (geographic region) can be changed but not the hl (locale/language), as it influences the text data returned by youtube, which is heavily used by our parser (i.e, the parser matches x views to get a viewcount, so that won't work with the japanese word for views).

A rework of the available options is in progress, so in the future the region will be configurable without having to mess with the code!

In the meantime, feel free to ping me if you need a more in depth review of it :)

from documentation.

TechnicalSuwako avatar TechnicalSuwako commented on June 29, 2024

I'll change it.
https://git.076.ne.jp/TechnicalSuwako/invidious-mod/-/commit/f8d4820740b15a32904a5d117296e8e4c5b946f1
Please check it out.

from documentation.

SamantazFox avatar SamantazFox commented on June 29, 2024

@TechnicalSuwako Yeah, that's much better :)

Btw, for the default locale, don't modify the source code directly. Instead use the config option for that matter:
https://git.076.ne.jp/TechnicalSuwako/invidious-mod/-/commit/f8d4820740b15a32904a5d117296e8e4c5b946f1#59c4f02b4ed5c42144db4086446aa59b37f4674b_41_39

This is documented in the example config file:
https://github.com/iv-org/invidious/blob/master/config/config.example.yml#L457-L496

from documentation.

SamantazFox avatar SamantazFox commented on June 29, 2024

Also, please enable statistics! https://youtube.076.ne.jp/api/v1/stats

from documentation.

TechnicalSuwako avatar TechnicalSuwako commented on June 29, 2024

I've changed it.

from documentation.

unixfox avatar unixfox commented on June 29, 2024

@TechnicalSuwako could you please keep your instance up to date? it is more than one month old

from documentation.

unixfox avatar unixfox commented on June 29, 2024

No reply, removing the instance in 5cd02f1

from documentation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.