Giter Site home page Giter Site logo

Comments (6)

simoncarne avatar simoncarne commented on August 12, 2024 1

Thank you for offering a patch. I will figure out which CSS I am using and get back to you. I know that I am not using the multi-row from Aris-t2. I am using other CSS features.

Many thanks

from quantum-nox-firefox-dark-full-theme.

Izheil avatar Izheil commented on August 12, 2024

To me multirow works correctly even after the lastest update, but I see that you are using some other code to change the shape of tabs and their sizing, which is most likely the issue here.

You will have to check which part of the custom code you have is creating the issue, not much that I can do about it without knowing that.

Multirow tabs inherits the tab height from a global variable and uses that to calculate the sizing of tabs to calculate the max number of rows to show, if you want to force a tab height, you can change the value of "inherit" in this part of the code to the value in px that you want it to be:

#TabsToolbar {
        --tab-min-height: inherit !important;
    }

For example, for normal density the min value you can use without having issues on tabs is 29px, in the example you'd change it to:

#TabsToolbar {
        --tab-min-height: 29px !important;
    }

If you are using compact mode, the smallest size you can give the tabs is 20px of height.

Still, the problem is coming from some issue of other custom code you have to change the tabs, so you should probably check that first before changing multirow.

from quantum-nox-firefox-dark-full-theme.

simoncarne avatar simoncarne commented on August 12, 2024

@Izheil
Many thanks for your response. Looking again at what I have installed, I realise that I am running your Multiple Tabs software in conjunction with CustomCSSforFx from Aris-t2 (see https://github.com/aris-t2/customcssforfx). Is that a project that you are aware of?

I have tried eliminating that project altogether to see what happens with your MultiRowTab and the result is that various tab rows have different heights.

If you aren't aware of the Aris-t2 project, or not happy to have yours used in conjunction with it, I will need to do some more investigating to figure out how to proceed. But, if you are aware of the project and are happy to work with it, I can tell you that the conflict that is affecting the tab heights seems to be coming from the file ./css/tabs/tabs_multiple_lines-classic.css.

Any suggestions ... or do you recommend that I try to do more work on this for myself?

from quantum-nox-firefox-dark-full-theme.

Izheil avatar Izheil commented on August 12, 2024

I have tried eliminating that project altogether to see what happens with your MultiRowTab and the result is that various tab rows have different heights.

That shouldn't be happening:
TAB ROWS

Aris-t2 uses a different method for multirow, if you are using his multirow tabs, you shouldn't use the one here, that will most likely cause issues, and same the other way around, if using the one here, don't use the one there.

If you mean that you are just using other CSS code from that project (Knowing which css files you are using from there would help debug the issue), it shouldn't have any problem unless you were using code that is affecting the same part of the interface, which in this case, it is (the tabs area).

With that said, if you can tell me which css you are using from there, we can try to make a patch to make it work, otherwise I won't be able to help you.

from quantum-nox-firefox-dark-full-theme.

simoncarne avatar simoncarne commented on August 12, 2024

I have solved the problem. Many thanks once again, @Izheil, for the advice above, which pointed me in the right direction.

In case anyone else arrives at this page in search of a solution to the same problem, it arose in my case because I was importing (from Aris-t2's CustomCSSforFx) an old version of the "tabs_multiple_lines.css" file designed for Firefox 81 (ie I was using /css/tabs/tabs_multiple_lines_fx81.css.) I have replaced that with the latest version of the file (ie /css/tabs/tabs_multiple_lines.css) and the problem has resolved itself.

from quantum-nox-firefox-dark-full-theme.

Izheil avatar Izheil commented on August 12, 2024

Good to know you got it working! I'll close this then.

from quantum-nox-firefox-dark-full-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.