Tests\Graby\GrabyFunctionalTest::testDate is failing with incorrect date

[j0k3r]

Tests\Graby\GrabyFunctionalTest::testDate is failing with incorrect date

[j0k3r]

Looks ok on the last build: https://travis-ci.org/j0k3r/graby/builds/296148904
Did you fix it or does it fix by itself? 🤔

[Kdecherf]

The fail was seen on my machine

[aaa2000]

I have the same failed since at least the 16th October. Travis was OK but in local the test failed.

[j0k3r]

Which version of PHP did you use?

[aaa2000]

I use PHP 7.0.22

[Kdecherf]

7.1.10 here

[j0k3r]

Ok I'm still working on 5.6 on my dev machine

[aaa2000]

The problem is not the php version, I have not the extension php tidy installed

[aaa2000]

Should we skip the test if the extension php tidy is not installed or should we add ext-tidy in require-dev section of composer.json ?

[Kdecherf]

This test is clearly indicating that without ext-tidy some data are incorrectly extracted, we can't just skip it imo.

[j0k3r]

We shouldn't add tidy as requirement.
But we can try: https://github.com/j0k3r/php-readability/blob/master/tests/ReadabilityTest.php#L26