Giter Site home page Giter Site logo

Comments (3)

jacebrowning avatar jacebrowning commented on June 9, 2024 1

It doesn't feel too natural that updating sparse_paths and then re-running install or update doesn't pull in the new paths defined.

I agree and would be open to a PR that changes that.

from gitman.

jacebrowning avatar jacebrowning commented on June 9, 2024 1

@ksharma-bdai Right now the README calls out Git 2.8+, but if we need to bump that to include newer features, that's fine.

I didn't write most of the sparse_paths logic so I'd recommend looking through git blame to locate the original PR authors.

from gitman.

ksharma-bdai avatar ksharma-bdai commented on June 9, 2024

Hi @jacebrowning, I ran into this for a very specific use case and would like to take a shot at making a PR.

A couple of questions from a quick look through the source:

Is there a minimum version of git that is supported? I noticed gitman currently manually creates .git/info/sparse-checkout rather than using git sparse-checkout <init/set/add/reapply/enable/disable> from git 2.25 (2020) I believe. Can understand if you want to support older versions of git, but just checking if I should update things to use the new command while I'm in here.

It seems like this is just a case of passing sprase_paths into update and checking if there's a mismatch, e.g.:

  • full checkout -> sparse (new entries)
  • sparse -> updated sparse (updated entries)
  • sparse -> full checkout (all entries removed)

I'm assuming we'd want to do this check somewhere towards the end of update here after all of the clone/local changes present/etc. checks?

If that all sounds reasonable, I can put up a PR with updated test cases (for the above transitions) in the near-ish future.

from gitman.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.