Giter Site home page Giter Site logo

Comments (2)

x42 avatar x42 commented on August 14, 2024

This seems like a gentoo (and similiar distro) specific packaging problem.

--enable-nejack, --disable-netjackwould only be a workaround for such situations, not a solution.
There are a lot of very similar issues and jack won't get an option for all of those. This needs to be fixed by the distributor.

e.g. Step (3) s/libopus/libc/ -- what if the user uninstalls libc for some reason? or less dramatic: The user removes libsndfile? You are suggesting that jack should have an option for all its dependencies and and have them set to disabled by default?

Any sane GNU/Linux distribution will not allow Step (3) without warning the user or explicitly requiring confirmation.
This problem cannot be fixed by jack.

from jack2.

karllinden avatar karllinden commented on August 14, 2024

No, I didn't mean all dependencies should be disabled by default. That is completely different. Libc and libsndfile are mandatory to build, libopus is not. Furthermore, the user is on his/her own if he/she decides to remove libc or libsndfile. (The package manager will complain, eventually). The case with libopus is different in the sense that the build system might decide to build against libopus event if the user thinks it doesn't. On the contrary, the user will always know jack builds against libsndfile and libc; the build system cannot spontaneously decide whether or not to use libc.

I have no problems with libopus being detected and built against if the user does not make a choice to turn it off. However, if the user has libopus and does not want jack to be built with netjack then he/she has to remove libopus (or at least make sure waf doesn't find the headers) in order to build properly. It currently is that way. It is not very convenient nor does it respect the user's right to choose. (There are not a lot of packages that require libopus, hence it will not likely be installed on a system without jack requiring it, but such a situation might arise).

We (the maintainers) can of course add some kind of hack so that it would seem like opus is not accessible on the system, but a solution upstream would be superior to such a hack. We could also hard-enable it, but that just does not make any sense - everyone does not want netjack.

It would be a solution. We would get rid of the problems arising from the package manager not knowing what libraries the program built against because of a refractory build system.

If you would rather choose a --no-netjack option that would be fine. As long as the dependency can be controlled in some way.

from jack2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.