Remove Google JavaScript Compiler.jar

[jackspirou]

Remove Google JavaScript Compiler.jar

[jackspirou]

Still using the google javascript closure compiler, but it is hidden now. It is wrapped around a gulp plugin :)

[dsmontoya]

Why didn't you use Uglify2 instead?

[jackspirou]

@dsmontoya I started with Uglify2 or gulp-minify, but there were a few issues:

• minifiying multiple files to a single file was not intuitive and needed gulp-concat.
• a copy of the original source was also placed in the dist folder (never figured out what options existed or how they worked to remove it) which might be good behavior, but we haven't discussed it.
• The final resulting single concatenated minified file had issues and broke methods like getFlashVersion().

The only pro was that the minification was slightly better than the google closure compiler by a few bytes (like ~0.6 KB).

Since we currently are using the google closure compiler I decided it would be fine to stick with it for now until we can resolve the issues above with gulp-minify. Also the resources we were able to find for the google closure compiler allowed for easy use with Gulp:

• https://developers.google.com/closure/compiler/?hl=en
• https://github.com/google/closure-compiler
• https://www.npmjs.com/package/google-closure-compiler
• https://www.npmjs.com/package/closurecompiler
• https://www.npmjs.com/package/gulp-closure-compiler
• https://en.wikipedia.org/wiki/Google_Closure_Tools

All that said, if later we can figure out how to get Uglify2 working properly, and it gets us better compression/minification I think we should switch to it :)