Full Inspector does not recognise custom editors for specific enum types

[jacobdufault]

Full Inspector does not recognise custom editors for specific enum types

[XScorpion2]

Actually, I stand corrected, Full Inspector does not recognize a custom editor for a specific enum type.

Code Example:

[System.Flags]
public enum Direction
{
    UP = 1,
    DOWN = 2,
    LEFT = 4,
    RIGHT = 8,
}

using UnityEngine;
using UnityEditor;
using FullInspector;

[CustomPropertyEditor(typeof(Direction))]
public class DirectionEditor : PropertyEditor<Direction>
{
    public override Direction Edit(Rect region, GUIContent label, Direction element)
    {
        return (Direction)EditorGUI.EnumMaskField(region, label, element);
    }

    public override float GetElementHeight(GUIContent label, Direction element)
    {
        return EditorStyles.numberField.CalcHeight(label, 1000);
    }
}

[jacobdufault]

I'll update the default enum property editor to correctly handle [Flags].

I've additionally adjusted the property editor resolution order to allow for enums to be overriden.

If you want this fix now, then please update PropertyEditor.GetCachedEditors to

private static List<IPropertyEditor> GetCachedEditors(Type propertyType) {
    List<IPropertyEditor> editors;

    if (_cachedPropertyEditors.TryGetValue(propertyType, out editors) == false) {
        editors = new List<IPropertyEditor>();
        _cachedPropertyEditors[propertyType] = editors;

        IPropertyEditor editor;

        // arrays always need special handling; we don't support overriding them
        if ((editor = ArrayPropertyEditor.TryCreate(propertyType)) != null) editors.Add(editor);

        // try to add a user-defined editor
        if (UserDefinedNonGenericPropertyEditors.Value.ContainsKey(propertyType)) {
            editors.Add(UserDefinedNonGenericPropertyEditors.Value[propertyType].Value);
        }

        // try and create an editor from one of the user-defined generic property editors
        if ((editor = TryCreateFromGenericPropertyEditor(propertyType)) != null) editors.Add(editor);

        // try to create an inherited property editor
        if ((editor = TryCreateInheritedPropertyEditor(propertyType)) != null) editors.Add(editor);

        // enums come after generic & inherited to allow them to be overridden
        if ((editor = EnumPropertyEditor.TryCreate(propertyType)) != null) editors.Add(editor);

        // try and create an editor for abstract/interface type
        if ((editor = AbstractTypePropertyEditor.TryCreate(propertyType)) != null) editors.Add(editor);

        // try and create a reflected editor; will only fail for arrays or collections,
        // which should be covered by the array editor
        if ((editor = ReflectedPropertyEditor.TryCreate(propertyType)) != null) editors.Add(editor);
    }

    return editors;
}

Thanks.

[XScorpion2]

I love you sir!

[jacobdufault]

Additionally, EnumPropertyEditor will be changed to this in 1.2:

/// <summary>
/// Provides a property editor for enums.
/// </summary>
internal class EnumPropertyEditor : IPropertyEditor {
    public object Edit(Rect region, GUIContent label, object element) {
        Enum selected = (Enum)element;

        if (Attribute.IsDefined(selected.GetType(), typeof(FlagsAttribute))) {
            return EditorGUI.EnumMaskField(region, label, selected);
        }

        return EditorGUI.EnumPopup(region, label, selected);
    }

    public float GetElementHeight(GUIContent label, object element) {
        return EditorStyles.popup.CalcHeight(label, 100);
    }

    public static IPropertyEditor TryCreate(Type dataType) {
        if (dataType.IsEnum == false) {
            return null;
        }

        return new EnumPropertyEditor();
    }
}