Comments (7)
Same here.
from atom-git-control.
I solved an error from popping up with this 4cc3e03 commit. However this only prevents an error message from being thrown and instead shows this message to the user:
Is there something else that could be done in this case ( opening a non vcs project )?
from atom-git-control.
@MarcelMue In my case, I had the problem when I tried to open git-control on non vcs folder that contains multiple vcs folders. Maybe, in that case, we should be able to choose, in a list, for which vcs sub-folder we want to open git-control. If there is not any vcs sub-folder, then displaying an error message would be a good idea. I think a notification here is a better idea than a simple error message in an empty git-control tab (more user-friendly).
from atom-git-control.
@MaximeWillinger I started playing with this locally but it seems pretty difficult so far to find repo folders. My approach right now would be to get the folders in the project root, check them for repos and then get the subfolders in the ones that aren't repos and repeat. I thougth about doing this for only 5 layers or so because otherwise the amount of folders checked could get crazy high. I am open to other approaches if anyone has a better idea, for now I am going to continue implementing it this way.
from atom-git-control.
I have worked on a project that did similar things and you don't really have a choice. crawling the tree is the right/only way to do it, unless you have a registry of git folders (which we can't assume).
One thing I can say that we implemented was giving the user a setting to tweak how deep the search should be and also whether to break off the search in folders that had more than n folders (n was userconfigurable and defaulted to 30)
To be honest, one could probably set depth to 2 and n to 100 and nobody would ever notice. Oh and be sure not to recurse into the .git folders ;-)
from atom-git-control.
I'm also having the same problem, do not know if the OS can influence, but I'm using ElementaryOS.
from atom-git-control.
Is this bug still a problem?
from atom-git-control.
Related Issues (20)
- Uncaught Error: Command failed: ls `git rev-parse --git-dir` | grep rebase || echo norebase"ls" ...
- copy text from the git control logger or diff views / panes. Feature request / enhancement.
- Unable to set correct project folder
- No credential popup for non github git servers
- Unable to write commit message started with #
- Uncaught TypeError: Cannot read property 'local' of undefined
- Uncaught TypeError: Cannot read property 'split' of undefined HOT 6
- cannot resize information pane HOT 1
- Uncaught TypeError: Path must be a string. Received undefined HOT 4
- Uncaught TypeError: Cannot read property 'split' of undefined HOT 10
- Uncaught TypeError: this.setworkspacetitle is not a function HOT 2
- Uncaught TypeError: Cannot read property 'workingDirectory' of null
- Uncaught TypeError: Cannot read property 'split' of undefined HOT 36
- Cannot read property 'split' of undefined HOT 1
- Unexplained disappearance
- Cannot spawn /usr/bin/ssh.exe HOT 1
- Deprecated? HOT 7
- Uncaught TypeError: Cannot read property 'split' of undefined HOT 36
- Git-control GUI from Atom GUI HOT 1
- Error with a bitbucket repository
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from atom-git-control.