Parsing YAML causes a segfault.

[jaegertracing]

Parsing YAML causes a segfault.

[rnburn]

In this code

template <typename ValueType, typename KeyType, typename DefaultValueType>
ValueType findOrDefault(const YAML::Node& node,
                        KeyType&& key,
                        DefaultValueType&& defaultValue)
{
    const auto valueNode = node[key];
    if (!valueNode.IsDefined()) {
        return defaultValue;
    }
    return valueNode.template as<ValueType>();
}

DefaultValueType will be a reference. I think what you want is

return valueNode.template as<typename std::decay<ValueType>::type>();

[rnburn]

Or just change to not use a forwarding reference. It's not like your modifying key or defaultValue.

[rnburn]

cc @isaachier

[black-adder]

A PR would be much appreciated :)

[rnburn]

I put in #11. I don't know that it fixes the issue, but it will at least prevent you from trying to cast to reference types.

I expect the yaml-cpp API might require you to check the type before call as.

[isaachier]

Ya I'm considering giving up yaml-cpp in favor of nlohmann/json. The only concern is the compatibility with Go configs, but I think converting YAML to JSON is no big deal.