Giter Site home page Giter Site logo

Comments (5)

isaachier avatar isaachier commented on May 23, 2024

Good catch. Will update now. Thanks.

from jaeger-client-cpp.

isaachier avatar isaachier commented on May 23, 2024

@rnburn, while doing this, discovered that Jaeger does not implement new OpenTracing dynamic loading function. Where do I use OPENTRACING_DECLARE_IMPL_FACTORY? In the implementation file (DynamicLoad.cpp) or in the tracer factory header (TracerFactory.h)?

from jaeger-client-cpp.

rnburn avatar rnburn commented on May 23, 2024

Yes, in the implementation file. It was added to support building on windows.

@mdouaihy updated it as part of his PR. You can see https://github.com/mdouaihy/jaeger-client-cpp/blob/9091fc42ed356cd51e640c039623279e0a4de761/src/jaegertracing/DynamicLoad.cpp

from jaeger-client-cpp.

ppggff avatar ppggff commented on May 23, 2024

It would be better to add the version number of corresponding opentracing-cpp with the released binary plugin library file.

from jaeger-client-cpp.

isaachier avatar isaachier commented on May 23, 2024

Fixed in #120.

from jaeger-client-cpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.