Traces not showing up in jaeger.

[jaegertracing]

Traces not showing up in jaeger.

[yurishkuro]

this might be a sign of the wrong timestamps emitted by C++ client. Jaeger thrift defines timestamps as microseconds since epoch. If they are not scaled appropriately, then the search may be mismatching on the time range.

[isaachier]

I had this issue before with @bcherukuri. It had been an issue in the client usage of system_time vs. steady_time. That was already addressed and we got traces. I'll try your example locally and get back to you.

[isaachier]

Found your issue. Relates to opentracing/opentracing-cpp#29. Try setting timestamps manually and see the results.

[isaachier]

Regardless, I somehow get the spans using your code locally.

[isaachier]

[rnburn]

Yes, it I see them if I manually set the timestamps.

It looks like Jaeger is missing logic like this to set the timestamps if they're default constructed.

[yurishkuro]

It looks like Jaeger is missing logic

do you mean the backend? Timestamps must be set by the tracer impl.

[isaachier]

But I ran your example and it worked. Are you sure it is not something I fixed recently?

[rnburn]

I mean the client library. The equivalent of what's done here in the go tracer.

[isaachier]

I'm also not sure why the convenience method StartSpan in the base class does not simply do this before passing the timestamp onto the more detailed StartSpanWithOptions pure virtual method.

[rnburn]

Isn't that what you complained about in this issue: opentracing/opentracing-cpp#29.

But regardless of whether StartSpan sets the timestamps or not you should be able to call StartSpanWithOptions using default constructed timestamps and have the tracer determine the times for you. That's the behavior in Go as well.

[isaachier]

It is the same issue indeed. My only qualm with the comparison with Go is that Go uses nil which is not a valid timestamp. Technically, January 1st, 1970 12:00:00 A.M. is a timestamp, even if no one should practically use it.

[rnburn]

Go's not using nil. It sets if time.IsZero() (see the comments) which is the same thing as setting to the epoch.