Giter Site home page Giter Site logo

Comments (3)

ringerc avatar ringerc commented on May 25, 2024

I just did

diff --git a/CMakeLists.txt b/CMakeLists.txt
index d6c99c9..66539b1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -60,7 +60,7 @@ hunter_add_package(opentracing-cpp)
 # Not `${hunter_config}` because OpenTracing provides its own
 # OpenTracingConfig.cmake file
 find_package(OpenTracing CONFIG REQUIRED)
-list(APPEND LIBS OpenTracing::opentracing-static)
+list(APPEND LIBS OpenTracing::opentracing)
 list(APPEND package_deps opentracing-cpp)
 
 hunter_add_package(nlohmann_json)

but haven't checked whether that's sane with the jaeger static lib. The Jaeger static lib should probably not link to the opentracing static lib directly anyway; the app should be linking both.

from jaeger-client-cpp.

isaachier avatar isaachier commented on May 25, 2024

I think I originally envisioned the user deciding whether Jaeger would be a shared lib or static lib so I wanted all dependencies to be the same. Nonetheless, I have changed my mind since then and this makes more sense so will fix it.

from jaeger-client-cpp.

isaachier avatar isaachier commented on May 25, 2024

This can be resolved using -DHUNTER_BUILD_SHARED_LIBS=ON. See https://docs.hunter.sh/en/latest/reference/user-variables.html#hunter-build-shared-libs.

from jaeger-client-cpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.