Comments (4)
That logging interface was recently added and hasn't actually been put into an OT release yet.
But I can a release for it if it's something you're waiting on.
from jaeger-client-cpp.
@rnburn Good to know. Useful interface :)
No rush. To make any of this work requires running with my integration branch that currently merges in flush-on-close, save-finish-span-logs and local-dependencies-support topic branches, all pending PRs. So building a recent OT is hardly a hassle on top. @isaachier may have an opinion about the next jaeger cpp-client release that's relevant though.
(The mess with Thrift in #45 means Jaeger cpp-client is in practice confined to deployments that can compile their own local Thrift anyway, either via Hunter or direct local install.)
BTW, I went looking for a Span.Log(std::vector<LogRecord::Field>)
first, but there's only the initializer list interface. It might make sense to add this as a compromise between the two: you can supply key/value logs constructed dynamically but don't have to keep track of them yourself until Finish time, you can still just append them to the span directly.
In any case the logs support added in #58 works for me.
from jaeger-client-cpp.
@rnburn (PR #58 can't pass CI until there's a newer OT to fetch, but it's not hurting me any)
from jaeger-client-cpp.
@ringerc -- The current interface was copied over from Go's API.
In the PR, we did discuss another interface like what you're suggesting
opentracing/opentracing-cpp#43 (comment)
but decided to support only the FinishSpanOptions initially to keep things simple.
You might put in an issue to OT-cpp for being able to add them directly to the span. One of the open questions is whether you should also be able to specify the timestamp in such an API.
from jaeger-client-cpp.
Related Issues (20)
- Provide access to context HTTP Header name
- Jaeger 32 bit C/C++ client required
- QUESTION: Can not use with hunter manager
- how to release version to real scene
- Unit test: Socket.testFailBind fails when run as "root" HOT 6
- Can we please ditch hunter HOT 1
- Enable ppc64le arch for jaeger-client-cpp
- Unable to build windows in a pipeline.
- Add support for adding tracer tags via config yaml HOT 1
- My jaeger version is 1.23, and the jaeger-collector component has enabled --sampling.strategies-reload-interval, but the collected logs show that the sampling strategy is still old HOT 4
- Envoy - failed to load dynamic library opentracing versions are incomptable
- `RemoteReporter::report()` is blocked
- Default queue size & buffer flush interval are not used when reading configuration from YAML
- Issue facing while trying to build jaeger-client-cpp
- Compilation issue on Ubuntu 20.04 HOT 2
- When the sampling type is rate, the number of actual results is equal to the number of threads multiplied by the configured rate parameter
- warning const' was hidden [-Woverloaded-virtual] when using jaeger client with opentracing libraries
- Enablement TravisCI integration for IBM ppc64le architecture HOT 1
- Deprecate Jaeger C++ SDK HOT 3
- [Bug]: W3C Propagation is wrongfully encoding debug span flag into traceparent HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jaeger-client-cpp.