Linting question

[liusida]

Linting question

[atlasan]

Hey @liusida, if you want to have a check for more advanced features and possibilities, you can have a try with the forwardcompatible branch. There you get the possibility to register and unregister to callbacks making easier to have multiple event handlers to the same event names (compatibles with previous ones).
https://github.com/daniel-lewis-ab/litegraph.js/tree/forwardcompatible
Just consider trying your code (and current code) in the three versions: main Litegraph repo, and in @daniel-lewis-ab repo check the featurless reversion and the improved forwardcompatible
Let's have fun and see you around ^ _ ^

[daniel-lewis-ab]

My fork has 0 vulnerabilities and 25 linting problems. ;)

[daniel-lewis-ab]

Atlasan, I've been trying to reach you and haven't had any of my accounts this whole time (laptop MOK problems) I hope you're doing well and heard the good parts. I'd love to voice chat some time this week to go over the details of what has happened so we're on the same page. On Wed., May 29, 2024, 09:56 Daniel Lewis, ***@***.***> wrote:

…

Hi, Yeah, the main branch is what Atlasan and I have been experimenting with. The reversion branch is probably going to be the final code and is well behind main branch. I think the goal is to get a stable featureless upgrade to ES6 in 1.0, and then look at what we want to add from the changes we've been making in main and integrate them. You're welcome to approach things how you like. Nice to hear from you. On Wed., May 29, 2024, 01:31 Liu Sida, ***@***.***> wrote: > Hi @liusida <https://github.com/liusida>, I actually started using lint > only two days ago, and my experience with ES6 is really low too, I kinda > prefer the old school. But that didn't stopped me to read the whole source > many times and try to improve it and add functionalities. Npm too is not > actually required in this project. You can get the single litegraph.js > library and go with that. I find it beautiful and right somehow and that > this would work on old devices too. But yes, now it's time to make new > releases with newer technologies and expand and improve this beautiful > library. > > Thanks @atlasan <https://github.com/atlasan> . Thanks for telling me > this is not unexpected. I am new to the modern JS, and I was thinking it > might because I didn't understand the setup correctly. xD > Okay, I'll just open the folders and files and start reading. > > — > Reply to this email directly, view it on GitHub > <#463 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AC36LN3FIJWNITSPQ3IKQSTZEV745AVCNFSM6AAAAABFVS7L3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZWG4ZDMOJSGA> > . > You are receiving this because you commented.Message ID: > ***@***.***> >

[atlasan]

Hi @liusida, I actually started using lint only two days ago, and my experience with ES6 is really low too, I kinda prefer the old school. But that didn't stopped me to read the whole source many times and try to improve it and add functionalities.
Npm too is not actually required in this project. You can get the single litegraph.js library and go with that. I find it beautiful and right somehow and that this would work on old devices too.
But yes, now it's time to make new releases with newer technologies and expand and improve this beautiful library.

[liusida]

Hi @liusida, I actually started using lint only two days ago, and my experience with ES6 is really low too, I kinda prefer the old school. But that didn't stopped me to read the whole source many times and try to improve it and add functionalities. Npm too is not actually required in this project. You can get the single litegraph.js library and go with that. I find it beautiful and right somehow and that this would work on old devices too. But yes, now it's time to make new releases with newer technologies and expand and improve this beautiful library.

Thanks @atlasan . Thanks for telling me this is not unexpected. I am new to the modern JS, and I was thinking it might because I didn't understand the setup correctly. xD
Okay, I'll just open the folders and files and start reading.

[daniel-lewis-ab]

Hi, Yeah, the main branch is what Atlasan and I have been experimenting with. The reversion branch is probably going to be the final code and is well behind main branch. I think the goal is to get a stable featureless upgrade to ES6 in 1.0, and then look at what we want to add from the changes we've been making in main and integrate them. You're welcome to approach things how you like. Nice to hear from you.

…

On Wed., May 29, 2024, 01:31 Liu Sida, ***@***.***> wrote: Hi @liusida <https://github.com/liusida>, I actually started using lint only two days ago, and my experience with ES6 is really low too, I kinda prefer the old school. But that didn't stopped me to read the whole source many times and try to improve it and add functionalities. Npm too is not actually required in this project. You can get the single litegraph.js library and go with that. I find it beautiful and right somehow and that this would work on old devices too. But yes, now it's time to make new releases with newer technologies and expand and improve this beautiful library. Thanks @atlasan <https://github.com/atlasan> . Thanks for telling me this is not unexpected. I am new to the modern JS, and I was thinking it might because I didn't understand the setup correctly. xD Okay, I'll just open the folders and files and start reading. — Reply to this email directly, view it on GitHub <#463 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC36LN3FIJWNITSPQ3IKQSTZEV745AVCNFSM6AAAAABFVS7L3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZWG4ZDMOJSGA> . You are receiving this because you commented.Message ID: ***@***.***>

[liusida]

Hi, Yeah, the main branch is what Atlasan and I have been experimenting with. The reversion branch is probably going to be the final code and is well behind main branch. I think the goal is to get a stable featureless upgrade to ES6 in 1.0, and then look at what we want to add from the changes we've been making in main and integrate them. You're welcome to approach things how you like. Nice to hear from you.
…
On Wed., May 29, 2024, 01:31 Liu Sida, @.> wrote: Hi @liusida https://github.com/liusida, I actually started using lint only two days ago, and my experience with ES6 is really low too, I kinda prefer the old school. But that didn't stopped me to read the whole source many times and try to improve it and add functionalities. Npm too is not actually required in this project. You can get the single litegraph.js library and go with that. I find it beautiful and right somehow and that this would work on old devices too. But yes, now it's time to make new releases with newer technologies and expand and improve this beautiful library. Thanks @atlasan https://github.com/atlasan . Thanks for telling me this is not unexpected. I am new to the modern JS, and I was thinking it might because I didn't understand the setup correctly. xD Okay, I'll just open the folders and files and start reading. — Reply to this email directly, view it on GitHub <#463 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC36LN3FIJWNITSPQ3IKQSTZEV745AVCNFSM6AAAAABFVS7L3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZWG4ZDMOJSGA . You are receiving this because you commented.Message ID: @.>

Hi @daniel-lewis-ab , your fork seems great to me. I appreciate that you and @atlasan split the huge litegraph.js into several files, very much code-reader-friendly. xD

I wonder when will this fork become a stable featureless upgrade to ES6, so I can try to add new small but lovely features. Thanks.