Giter Site home page Giter Site logo

Update workflows about lobsterpy HOT 4 CLOSED

jageo avatar jageo commented on June 12, 2024 1
Update workflows

from lobsterpy.

Comments (4)

JaGeo avatar JaGeo commented on June 12, 2024 1

Could you make the precommit part of the workflow so that we don't run into this issue anymore?

from lobsterpy.

naik-aakash avatar naik-aakash commented on June 12, 2024 1

Btw, and I am not sure why Pylint did not run on the PR ( #107 ) raised in the first place. It just seems to have run only the test workflow (Thus, all tests seemed to pass). Pylint runs for me always on my repo, so all linitng checks are run on the code, and all the issues are raised if any exist on each commit and then could be solved.

I think I need to check a bit more in detail why did this happen.

from lobsterpy.

naik-aakash avatar naik-aakash commented on June 12, 2024

Hi Janine, thanks for this issue. So I think the problem is Black is not in pylint workflow, but I have added this check in pre-commit config. If pre-commit is used before pushing any commits, this should not happen in the future. Maybe I can write this in the README file as well on how to contribute.

I will add black runs in the pylint workflow as well and raise a PR for the updated pylint workflow. Sorry for the inconvenience

from lobsterpy.

naik-aakash avatar naik-aakash commented on June 12, 2024

Sure. I will have a look at how to do it. Should be fairly quick, I think

from lobsterpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.