Comments (4)
Could you make the precommit part of the workflow so that we don't run into this issue anymore?
from lobsterpy.
Btw, and I am not sure why Pylint did not run on the PR ( #107 ) raised in the first place. It just seems to have run only the test workflow (Thus, all tests seemed to pass). Pylint runs for me always on my repo, so all linitng checks are run on the code, and all the issues are raised if any exist on each commit and then could be solved.
I think I need to check a bit more in detail why did this happen.
from lobsterpy.
Hi Janine, thanks for this issue. So I think the problem is Black is not in pylint workflow, but I have added this check in pre-commit config. If pre-commit is used before pushing any commits, this should not happen in the future. Maybe I can write this in the README file as well on how to contribute.
I will add black runs in the pylint workflow as well and raise a PR for the updated pylint workflow. Sorry for the inconvenience
from lobsterpy.
Sure. I will have a look at how to do it. Should be fairly quick, I think
from lobsterpy.
Related Issues (20)
- some error HOT 2
- Update readme
- Orbital-resolved automatic analysis HOT 2
- Orbital resolved data in featurizer
- Cation-anion modus does not work for materials without ions
- Save for automatic plots does not work correctly
- Easy lobsterin generation
- Add automatic analysis for COBIs, COOPs HOT 3
- Add more bond options
- Add more flexibility to lobsterin generation
- question HOT 7
- Documentation/Tutorial HOT 2
- Inputs based on POSCAR only
- Inspection for lobsterout
- Add support for compressed files
- Add options for DOSCAR.lobster plotting HOT 4
- Skip showing of plots in automatic analysis HOT 3
- Featurizer for ML HOT 2
- Test speed-up HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lobsterpy.