A few hours ago comfy changed the content in samplers.py, which resulted in errors like cannot import name 'CompVisVDenoiser' from 'comfy.samplers'

[jags111]

A few hours ago comfy changed the content in samplers.py, which resulted in errors like cannot import name 'CompVisVDenoiser' from 'comfy.samplers'

[picobyte]

pip install k-diffusion and

diff --git a/py/smZ_cfg_denoiser.py b/py/smZ_cfg_denoiser.py
index e6a4ce1..dfe3b5f 100644
--- a/py/smZ_cfg_denoiser.py
+++ b/py/smZ_cfg_denoiser.py
@@ -4,8 +4,8 @@ import torch
 from typing import List
 import comfy.sample
 from comfy import model_base, model_management
-from comfy.samplers import KSampler, CompVisVDenoiser, KSamplerX0Inpaint
-from comfy.k_diffusion.external import CompVisDenoiser
+from comfy.samplers import KSampler, KSamplerX0Inpaint
+from k_diffusion.external import DiscreteVDDPMDenoiser,CompVisDenoiser
 import nodes
 import inspect
 import functools
@@ -17,6 +17,15 @@ import itertools
 import torch
 from comfy import model_management
 
+
+class CompVisVDenoiser(DiscreteVDDPMDenoiser):
+    def __init__(self, model, quantize=False, device='cpu'):
+        super().__init__(model, model.alphas_cumprod, quantize=quantize)
+
+    def get_v(self, x, t, cond, **kwargs):
+        return self.inner_model.apply_model(x, t, cond, **kwargs)
+
+
 def catenate_conds(conds):
     if not isinstance(conds[0], dict):
         return torch.cat(conds)
@@ -318,4 +327,4 @@ def set_model_k(self: KSampler):
 class SDKSampler(comfy.samplers.KSampler):
     def __init__(self, *args, **kwargs):
         super(SDKSampler, self).__init__(*args, **kwargs)
-        set_model_k(self)
\ No newline at end of file
+        set_model_k(self)

[jags111]

I am on it to see if there is a workaround for same . else the node will be paused until rest workflow will continue.. The change in comfy sampler code will not allow CompVisDenoiser to work so have to add another module or new script to handle same.

[jags111]

all sorted and if any further open a new issue

[sapientsnap]

Thanks @jags111 for engineering and posting this.
But... I'm not quite sure what to do with that code you pasted.
I ran pip install k-diffusion, but the loading error still occurs, so I assume that code needs to be put somewhere?

Thanks for any assist.
(PS: Using Terminal on a Mac, if that makes a difference)

[noahjgreer]

Yes, this seems to have caused an issue with importing the Efficiency Nodes module. Any ideas on how to fix it?

[lord-lethris]

I have the same issue - I posted it here first.

LucianoCirino#235

I didn't know about this Branch of the project :)
I hope its fixable. in the interim, I might see if I can roll back the breaking Commit from ComfyUI.

[jags111]

will check as for now the particular node is throwing errors and will fix same and update.

[jags111]

oh will look into this again and update