Giter Site home page Giter Site logo

Comments (4)

jags111 avatar jags111 commented on August 22, 2024 1

For sure will do same and update this node. Thanks !

from efficiency-nodes-comfyui.

dnl13 avatar dnl13 commented on August 22, 2024

to discuss:
imho
this scrip only should contain Kosinkadinks "AnimateDiff Loader" because this is the only logical point to hook into the model.
Also this script should get all the same inputs like Kosinkadink "AnimateDiff Loader".
Kosinkadink added a ton of nice extra nodes like nodes to add the motion loras etc., which is missing in this script completly.
Also in the favor of node based editing, the user should add a video combine node by himself or this video combine node should be added to efficiency-nodes for faster acces instead of adding Kosinkadink VideoHelperSuite. Sometimes you will like to do stuff to the generated latent/image batches maybe.
Also thinking of maintaining this repo, this script is nice to have but is it realy mandetory ?
Just some thoughts

from efficiency-nodes-comfyui.

jags111 avatar jags111 commented on August 22, 2024

very right and so many changes daily in AD repo which i am very much aware of and it is fast evolving. To keep track of it and keep updating it is a mess and wont help much. Better to drop this node and remove unless something different is there. Thanks for the clarifications. I think any node which is duplicated is no purpose at all.

from efficiency-nodes-comfyui.

jags111 avatar jags111 commented on August 22, 2024

I think we will need to revise this node totally and for time being will keep it on hold as ANIMATE DIFF is going through a lot of changes

from efficiency-nodes-comfyui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.