Giter Site home page Giter Site logo

Comments (7)

jakebailey avatar jakebailey commented on June 8, 2024

This pyright action doesn't support the --verifytypes flag, which you seem to be using in your second manual run.

from pyright-action.

AbstractUmbra avatar AbstractUmbra commented on June 8, 2024

Oh that would definitely do it, thanks for letting me know. In that case, would a feature request for this be feasible?

from pyright-action.

jakebailey avatar jakebailey commented on June 8, 2024

It's definitely on my mental list. The question I was debating was what the pass-fail condition would be.

from pyright-action.

AbstractUmbra avatar AbstractUmbra commented on June 8, 2024

In my uneducated opinion, I suppose any error type would be a fail, but warning and info would pass?

from pyright-action.

jakebailey avatar jakebailey commented on June 8, 2024

In the type verifier mode, I don't think either are actually emitted.

The mode is also intended to be run on the installed version of a library (not locally on a repo), so I'm also questioning how that might work in CI either.

from pyright-action.

AbstractUmbra avatar AbstractUmbra commented on June 8, 2024

Oh I also forgot about that, currently I run an install step prior to this, which obviously isn't ideal.

from pyright-action.

jakebailey avatar jakebailey commented on June 8, 2024

I've added rudimentary support for --verifytypes in v1.0.5. There's no special GitHub integration, and a score under 100% will fail the build (e.g. matching the exit code of pyright).

from pyright-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.