Giter Site home page Giter Site logo

Comments (3)

donalmurtagh avatar donalmurtagh commented on June 30, 2024

Currently, the default value for the buttonType prop is "submit", so if you don't set this prop (or set it to "submit"), the form will be submitted when the upload button is clicked.

from react-images-upload.

bouthouri avatar bouthouri commented on June 30, 2024

NLTD: we should not create modules that doesn't work well with other components.
I think that this should work in general condition, which is that an input is a part from a form.
Thus this component should not submit a form by default but instead act as a simple input.
This is why it's an issue.

from react-images-upload.

donalmurtagh avatar donalmurtagh commented on June 30, 2024

@BOussama I agree that using submit as the default type for the input was not the best choice. However, if we were to change this default now, it would introduce an avoidable breaking change.

from react-images-upload.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.