Giter Site home page Giter Site logo

Comments (4)

ZacSweers avatar ZacSweers commented on June 8, 2024

Part of the way through implementing this, and just realized I should probably ask: Would this be part of the kotlin generation process or separate plugin functionality? I think I know the answer, but just to be clear...

Option 1 - Kotlin Gen

Pros:

  • Easy to plug in to the current code, no refactoring for sources retrieval code necessary.

Cons:

  • Would only run on kotlin generation

Option 2 - Separate plugin implementation

Pros:

  • Focused purpose and separation makes it easy to iterate on these checks for the future without tying them to kotlin generation
  • Depending on how fast it is, could add this as a preBuild task for more aggressive checking. Disablable via "noverify" param or something.

Cons:

  • None, really. Just more work, but probably for the better.

from rxbinding.

ZacSweers avatar ZacSweers commented on June 8, 2024

I liked option 2, and went with that if you want to take a look before I PR: https://github.com/hzsweers/RxBinding/tree/z/structured_checks

from rxbinding.

JakeWharton avatar JakeWharton commented on June 8, 2024

Option 2 is fine, although sharing code between the two plugins shouldn't be out of the question. I don't think it needs the option to disable, create a task called validateBindings (or something) and make the check task on the project depend on it.

from rxbinding.

JakeWharton avatar JakeWharton commented on June 8, 2024

Looks like it already caught some missing things, too!

from rxbinding.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.