Comments (4)
Part of the way through implementing this, and just realized I should probably ask: Would this be part of the kotlin generation process or separate plugin functionality? I think I know the answer, but just to be clear...
Option 1 - Kotlin Gen
Pros:
- Easy to plug in to the current code, no refactoring for sources retrieval code necessary.
Cons:
- Would only run on kotlin generation
Option 2 - Separate plugin implementation
Pros:
- Focused purpose and separation makes it easy to iterate on these checks for the future without tying them to kotlin generation
- Depending on how fast it is, could add this as a preBuild task for more aggressive checking. Disablable via "noverify" param or something.
Cons:
- None, really. Just more work, but probably for the better.
from rxbinding.
I liked option 2, and went with that if you want to take a look before I PR: https://github.com/hzsweers/RxBinding/tree/z/structured_checks
from rxbinding.
Option 2 is fine, although sharing code between the two plugins shouldn't be out of the question. I don't think it needs the option to disable, create a task called validateBindings
(or something) and make the check
task on the project depend on it.
from rxbinding.
Looks like it already caught some missing things, too!
from rxbinding.
Related Issues (20)
- Idea - Coroutine Support HOT 3
- androidx.appcompat.widget.SearchView support HOT 3
- Migrate to GitHub actions HOT 1
- Failed to resolve: com.jakewharton.rxbinding4:rxbinding:4.0.0 HOT 2
- I use RxView By Kotlin ,no find RxView but Java is ok. HOT 2
- How detect long press in Rxview .Touches HOT 1
- View click throttleFirst another way HOT 1
- RecyclerView can't use itemClicks HOT 1
- RxView.clicks needs tow clicks HOT 1
- throttleFirst way to avoid multiple clicks invalid when app first launched HOT 1
- Bug in comment for TextView.editorActions(handled: (Int) -> Boolean = AlwaysTrue)
- Getting java.lang.IllegalStateException: Expected to be called on the main thread but was RxCachedThreadScheduler HOT 1
- How to control BottomNavigationView.onNavigationItemSelected click switch fragment HOT 3
- Kotlin cannot recognize rxview, rxtextview HOT 2
- Version correspondence HOT 1
- RxView.clicks needs tow clicks
- Quest
- Observable textChanges() rxBinding4 HOT 2
- Run cb cmd command....qds
- Exception: No static method checkUiThread HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rxbinding.