Giter Site home page Giter Site logo

API 14 about rxbinding HOT 5 CLOSED

jakewharton avatar jakewharton commented on June 2, 2024
API 14

from rxbinding.

Comments (5)

JakeWharton avatar JakeWharton commented on June 2, 2024

I choose 15 by default for everything. There's no reason to support anything less in 99.99% of reasonable cases. That said, send a PR for this and I'll merge it.

from rxbinding.

ZacSweers avatar ZacSweers commented on June 2, 2024

Totally agree, it's just inertia for us since we have a ton of users (1 million...) still on API 14 devices for some reason.

That said, I just did some research, and found a solution for this via the ManifestMerger docs.

tools:overrideLibrary marker

A special marker that can only be used with uses-sdk declaration to override importing a library which minimum SDK version is more recent than that application's minimum SDK version.
Without such a marker, the manifest merger will fail. The marker will allow users to select which libraries can be imported ignoring the minimum SDK version.

Example, In the main android manifest :

<uses-sdk android:targetSdkVersion="14" android:minSdkVersion="2"
              tools:overrideLibrary="com.example.lib1, com.example.lib2"/>

will allow the library with the following manifest to be imported without error :

 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
        package="com.example.lib1">
        <uses-sdk android:minSdkVersion="4" />
    </manifest>

One can just add the following to their manifest to force their SDK versions over the library:

<uses-sdk tools:overrideLibrary="com.jakewharton.rxbinding" />

Much nicer solution than modifying the library itself for everyone, so no worries on needing a PR from me on it now :)

Thanks anyway! Wish I'd thought to look for override mechanisms before opening the issue.

from rxbinding.

JakeWharton avatar JakeWharton commented on June 2, 2024

Fair enough. If the customization becomes a problem, it's just one PR away...

from rxbinding.

siavashabdoli avatar siavashabdoli commented on June 2, 2024

can I override library api v 10?! 6 percent of android devices in our country have gingerbread android version. so we have to support 2.2.3. which functionality can meet problem in this case?!
@JakeWharton

from rxbinding.

JakeWharton avatar JakeWharton commented on June 2, 2024

As long as you don't use bindings which reference things added after API 10
it should probably work.

On Wed, Jun 15, 2016 at 9:24 AM Siavash A [email protected] wrote:

can I override library api v 10?! 6 percent of android devices in our
country have gingerbread android version. so we have to support 2.2.3.
which functionality can meet problem in this case?!


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#48 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAEEERIFuNiIn9QMTVKcK-45JfUBraQfks5qL_0HgaJpZM4Ffzbo
.

from rxbinding.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.