Comments (14)
While going back, commit 27254d8 seems to work
from coach.
are you saying that if you bisect, this commit is the last working commit?
from coach.
The "missing image" should be pretty easy for me to investigate, so I will do it now.
Please note 2 things:
- the error message seen doesn't come from coach, but rather comes from the upstream fsouza/go-dockerclient library, which essentially just runs a curl operation to the docker remote API. This issue may be an upstream issue.
- I was running into a scenario earlier where the docker library reported a missing image, but yet still created the container! Can you verify that the docker containers are not created.
from coach.
I'm investigating this now
from coach.
this issue could come from images that are not using the "latest" tag. Maybe I've missed something about passing image tags into the create process. I'll take a look there.
from coach.
I most certainly made a mistake related to image tags. I am fixing it now.
Note that I am checking some other operations that might also have issues now: pull, build, destroy
from coach.
@aleksijohansson #12 should fix issues related to images with tags in build, create, destroy, pull operations.
from coach.
PR merged.
from coach.
Tried with the latest version of coach from master. Same issue, different error. Please see screenshot: https://goo.gl/photos/Q72wymvanjV4B1nr8
Go 1.4.2
Docker 1.8.0-rc3 (tried also 1.7.0)
Also another issue after the tag changes in docker pull. Filing another issue for that.
from coach.
I can't recreate that image tag issue with the latest master.
Right now the only issue is the following: (Fedora 22)
[james@sd-60942 aleksi]$ coach create
(5)[OPERATION][CREATE]------ running create operation
(5)[NODES][NODE:memcache]--- CREATED INSTANCE CONTAINER [drupal_memcache_single FROM memcached:1.4.24] => 03949106eb0cf986965dec1ef2921a8aac2500413f83c5db3007eae2dc224f02
(5)[NODES][NODE:mariadb]---- CREATED INSTANCE CONTAINER [drupal_mariadb_single FROM mariadb:10.0.21] => ca89f4dcf17069f4cdc7cb0f4cac4c95f7e35b092d708372ecc7d97707d3665c
(3)[NODES][NODE:php]-------- ERROR FAILED TO CREATE INSTANCE CONTAINER [drupal_php_single FROM ] =>API error (500): No command specified
(3)[NODES][NODE:nginx]------ ERROR FAILED TO CREATE INSTANCE CONTAINER [drupal_nginx_single FROM ] =>API error (500): No command specified
This is a docker error message, which says that the image has no CMD entry in the Dockerfile. The only case where an image is legal without a CMD entry is if using the run operation.
I will remove pulled images and try it again.
from coach.
@aleksijohansson confirmed that I cannot recreate the image tag issue, after removing all images and starting from scratch. I can perform that pull, build and create options, and am only blocked by missing CMDs in the php and nginx images.
I will now investigate the images themselves to see if the docker client is confused about the missing CMDs.
from coach.
the "no command specified" issue is being caused by poor code in the create operation which is not properly identifying the image. I am working on fixing that now.
from coach.
This PR should fix the "no command specified" which seemed to occur in all build cases (as opposed to pull cases)
from coach.
Tested on Fedora, RancherOS and CoreOS and seems to be working really good now!
Whole workflow:
coach init git https://github.com/aleksijohansson/docker-drupal-coach
./prepare.sh (template specific)
coach pull
coach build
coach create
coach start
coach stop
coach remove
coach destroy
Fedora 22:
Go:
go version go1.4.2 linux/amd64
Docker:
Client:
Version: 1.8.1
API version: 1.20
Go version: go1.4.2
Git commit: d12ea79
Built: Thu Aug 13 02:39:27 UTC 2015
OS/Arch: linux/amd64
Server:
Version: 1.8.1
API version: 1.20
Go version: go1.4.2
Git commit: d12ea79
Built: Thu Aug 13 02:39:27 UTC 2015
OS/Arch: linux/amd64
RancherOS:
rancherctl version v0.3.3
Go:
go version go1.4.2 linux/amd64
Docker:
Client version: 1.7.0
Client API version: 1.19
Go version (client): go1.4.2
Git commit (client): 851c91a
OS/Arch (client): linux/amd64
Server version: 1.7.0
Server API version: 1.19
Go version (server): go1.4.2
Git commit (server): 851c91a
OS/Arch (server): linux/amd64
CoreOS:
CoreOS alpha (774.0.0)
Go:
go version go1.4.2 linux/amd64
Docker:
Client version: 1.7.1
Client API version: 1.19
Go version (client): go1.4.2
Git commit (client): 2c2c52b-dirty
OS/Arch (client): linux/amd64
Server version: 1.7.1
Server API version: 1.19
Go version (server): go1.4.2
Git commit (server): 2c2c52b-dirty
OS/Arch (server): linux/amd64
from coach.
Related Issues (17)
- Coach tool fails too quietly
- Default demos no longer work HOT 1
- coach pull doesn't work with tagged images HOT 6
- coach run operation doesn't work HOT 1
- Improve documentation HOT 9
- Commit operation creates image with no name HOT 1
- clean operation doesn't work HOT 3
- Operation: pull (and up) will pull the same image multiple times, if different nodes use it HOT 2
- init operation doesn't limit itself to the current path HOT 2
- The init yaml handler doesn't handle bad YAML tasks well HOT 1
- volume type nodes start and stop HOT 1
- run command gives error: cannot stop container HOT 1
- coach init git hangs HOT 15
- Manual dependencies are necessary in some cases
- Having a PULL type node would be usefull
- Command nodes easily orphan containers HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coach.