Comments (3)
Thank you for the detailed breakdown, and links to the Chromium example, that was helpful.
I've implemented it at ce4a159
Please feel free to suggest any changes or improvements, PRs (very) welcome.
from getid3.
Thanks for the implementation, I am so glad the references were helpful!
It is difficult with PRs without knowing the code well enough. As for the improvements, I think you already had a function to read the sizes - quicktime_read_mp4_descr_length()
is quite similar to quicktime_readESsize()
.
from getid3.
Sometimes I don't know the code that well myself -- most of getID3 was written 20 years ago...
You're right, quicktime_read_mp4_descr_length
is a better implementation, I have removed quicktime_readESsize
.
from getid3.
Related Issues (20)
- Reference getID3 from Google Apps Script HOT 1
- Purchasing a commercial license HOT 1
- `fread` length error in XMP HOT 2
- PHP Error as Severity: Notice Message: Undefined index: time_scale Filename: getid3/module.audio-video.quicktime.php Line Number: 335 HOT 1
- How to add Cover Image? HOT 1
- PHP Notice: Undefined index: data
- module.tag.id3v2 crashes PHP 8.2.12 if opcache enabled HOT 10
- fread(): Argument #2 ($length) must be greater than 0 HOT 1
- libxml_disable_entity_loader is deprecated HOT 3
- Garbage extracted from a RIFF tag in an AIFF file HOT 2
- Not work WRITE function in Windows 10/php7.4
- Write Synchronised lyric (SYLT)
- Unable to determine .gpx file HOT 5
- Deprecated: Implicit conversion from float ... to int loses precision HOT 7
- Mpeg duration error due to error in GOP parsing HOT 2
- Tag format "id3v2.3" is not allowed on "" files,
- Warning on PrintHexBytes function when $string is not a string. HOT 3
- Integrating into a Joomla 5 site
- Caught exception: Uninitialized string offset 0 HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from getid3.