Giter Site home page Giter Site logo

Bit rate for MP4 audio tracks about getid3 HOT 3 CLOSED

gino0631 avatar gino0631 commented on August 16, 2024
Bit rate for MP4 audio tracks

from getid3.

Comments (3)

JamesHeinrich avatar JamesHeinrich commented on August 16, 2024

Thank you for the detailed breakdown, and links to the Chromium example, that was helpful.
I've implemented it at ce4a159
Please feel free to suggest any changes or improvements, PRs (very) welcome.

from getid3.

gino0631 avatar gino0631 commented on August 16, 2024

Thanks for the implementation, I am so glad the references were helpful!

It is difficult with PRs without knowing the code well enough. As for the improvements, I think you already had a function to read the sizes - quicktime_read_mp4_descr_length() is quite similar to quicktime_readESsize().

from getid3.

JamesHeinrich avatar JamesHeinrich commented on August 16, 2024

Sometimes I don't know the code that well myself -- most of getID3 was written 20 years ago...

You're right, quicktime_read_mp4_descr_length is a better implementation, I have removed quicktime_readESsize.

from getid3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.