Giter Site home page Giter Site logo

Comments (4)

 avatar commented on September 25, 2024

First off, thank you Jaime for all the work you've put into this library over the years, much appreciated!

I'm looking at the here and, while I don't see any specification for an array of integers, the docs do specify the following:

*argv,: pointer to the first element of an array of integers containing the lower bound, upper bound, and pre-scaling factor, > whereby array data in the range lower < n < upper will be pre-scaled by p before processing.

Yet I do not see argv being used in the implementation. Is the documentation out of date (above quote is most recent built from doxygen)

On a side note, I could be wrong but it seems to me that the per-block malloc is unnecessary - you should just be able to cache data[n+1] and iterate over it instead. I would be happy to submit a PR to this affect once there are unit tests in place.

from libxtract.

jamiebullock avatar jamiebullock commented on September 25, 2024

Thanks @reakinator. You are right: the documentation is incorrect. I have also removed the unnecessary call to malloc() as you suggested.

from libxtract.

q-depot avatar q-depot commented on September 25, 2024

did you remove the arguments at all? tweaking them was affecting the results before, but I don't know whether it was needed or not.

from libxtract.

jamiebullock avatar jamiebullock commented on September 25, 2024

I think that might be a coincidence. In this commit, I also fixed a bug where *result wasn't being initialised before being used in calculation. It's possible the different results you were getting were just because of that bug.

Although the documentation previously specified arguments for argv, they weren't being used.

from libxtract.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.