Comments (4)
First off, thank you Jaime for all the work you've put into this library over the years, much appreciated!
I'm looking at the here and, while I don't see any specification for an array of integers, the docs do specify the following:
*argv,: pointer to the first element of an array of integers containing the lower bound, upper bound, and pre-scaling factor, > whereby array data in the range lower < n < upper will be pre-scaled by p before processing.
Yet I do not see argv being used in the implementation. Is the documentation out of date (above quote is most recent built from doxygen)
On a side note, I could be wrong but it seems to me that the per-block malloc is unnecessary - you should just be able to cache data[n+1] and iterate over it instead. I would be happy to submit a PR to this affect once there are unit tests in place.
from libxtract.
Thanks @reakinator. You are right: the documentation is incorrect. I have also removed the unnecessary call to malloc()
as you suggested.
from libxtract.
did you remove the arguments at all? tweaking them was affecting the results before, but I don't know whether it was needed or not.
from libxtract.
I think that might be a coincidence. In this commit, I also fixed a bug where *result wasn't being initialised before being used in calculation. It's possible the different results you were getting were just because of that bug.
Although the documentation previously specified arguments for argv, they weren't being used.
from libxtract.
Related Issues (20)
- failing mingw64 compilation HOT 6
- no more pd externals? HOT 2
- Python bindings in 2019 HOT 2
- Failing to build HOT 5
- Wrong Spectrum Computation HOT 1
- Mel spectrograms
- Build error on Windows
- Remove printf logging
- xtract_loudness() sometimes gives too-high values
- Building Pure Data external HOT 1
- Python bindings not installed with build HOT 4
- issue of building python bindings HOT 2
- round-off errors in generating spectra and other parameters HOT 5
- fabs warnings HOT 1
- Reinstate Pd external using flext
- LibXtract integrated in Ios application:
- python bindings HOT 1
- pip or conda package for python
- error in wavefile.cpp cannot install
- No downloads/releases anymore? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libxtract.