jandrewtorres/biowars309

BioWars309

biowars309's Issues

Close client / server javafx on javafx window close

No comments in Player class

populate inventory when buying cures/viruses

Client GamePlay UI - Finish

GamePlay UI needs to be done. Lots to do here.

Build out the ServerViewer javafx GUI.

The ServerViewer javafx gui is set up, but does not have much going on. It currently only has a label showing the number of connected clients. We want more than this. This should be built out as we are building the game model.

Begin creating game model.

Game should register players.

Game should have a timer.

Game should be an observable that updates the ServerViewerController.

Game model should update clients periodically.

Fixing indentation on line 27 and 28 in VirusMktController.java

ServerViewer - Game Event Log

It would be nice to have a text area on the serverviewer that shows game events. Such as "so and so joined the lobby". "Player 1 applied a virus to Player 2". etc.

Create the "skeleton" for a multithreaded game server, that accepts multiple clients.

Need to create a server that can communicate with multiple clients. We will do this using multithreading and sockets.

The server should be set up so that we can have a javafx server gui.

The server needs to listen for client connections and be able to receive messages from those clients. The server should also be able to send messages/updates to the clients.

No Comments in VirusMktController.java

Wire up Lobby to update when players join game. Protocol work.

When a cure/vaccine is clicked upon, it should display a model confirming the application of the vaccine/cure and apply to player.

Implement game log and logger messages

Need to log game events and exceptions using the java logging api and update clients with new game events. Log should be viewable in the serverviewer.

Indentation issue in CureFactory

			private String text;
		    private static Map map = new HashMap<>();

			static {
		        for (CURE_TYPE type : CURE_TYPE.values()) {
		            map.put(type.text, type);
		        }

and

			@Override
			public String toString() {
				return text;
			}
			
		    public static CURE_TYPE fromString(String text) {
		        return (CURE_TYPE) map.get(text);
		    }

Implement Vaccines into client UI Inventory and implement purchase functionality, similar to viruses.

Confusion in CURE_TYPE enum

Not quite sure why the Map is needed and am not fully sure what the purpose of having both Map and HashMap in place is since the map instance does not exist anywhere else. I would suggest a couple comments to clear things up.

drag and drop to attack opponents

Inconsistent method indentation/spacing in CureMktController.java

Some methods have a space after the closing "}" bracket before the next method starts, while other methods do not have such a space.

virus and cure to be combined under inventory

Wire up UI Forms and create controllers

Need to load fxml files and link controllers. Enable switching scenes and registering with the server

When a virus is dragged onto opponent, it should apply the virus to the selected opponent.

Currently, players can buy viruses but dragging and dropping them does not actually apply the virus to the selected opponent.

It should also remove the virus from the Player's inventory.

Inconsistent line spacing between methods in Player class

Once players are all have ready status, and there is more than one player, game should launch into gameplay screen.

Link up ClientUI

Lobby and Game Chat

Lobby and Game Chat would be a good feature, but not a first priority. Should be fairly easy to implement once the client server protocol / message schema is in place.

Remove SonarQube CodeSmells warnings.

When a client quits, the player should be removed from the lobby / game and the clients should be updated accordingly.

Line 33 in CureMktController.java. Indentation is inconsistent with the rest of the declared variables.

Line 33 is incorrectly indented compared to the rest of the variables declared in the block.

Alert dialogs when purchase fails

Client Game Lobby UI - Finish

The Lobby Game UI is being loaded and shown. It is wired into the application and being shown after the login scene. But it needs to be functional and be designed in scenebuilder.

It should have a working tableview that shows the players that are in the lobby. It should have a "I'm ready to play button".

The only functionality this should have is a player being able to press the "I'm ready to play" button. Once all players have pressed this button the game will send a message to clients that will launch the clients into gameplay screen.

Line 38 in GameModel.java. Input to GAME_STATUS as String n should be renamed to be more intuitive.

Comments needed in GameModel.java

Create vaccine model/factory in similar fashion to viruses.

Vaccines have not been built into the model.

• Abstract vaccine/cure class
• Concrete vaccine/cure classes
• Vaccine/Cure Factory class

Add sonarcloud.io svg badges in readme

Remove forms.assets and change to just assets

No need for the src/forms/assets/ anymore. See project structure.

The Login.fxml will need the new path to biohazard.png once move is made.

Configure project for travis ci and sonarqube.

add static UI forms

Add components for displaying game information and player interaction

Client should exit if server exits.

Adding modals for viruses/cures

Multiple subclasses of viruses

Protocol design. XML Document format sent as messages over sockets between server and UI.

Begin with registering clients with server.
Then we must move on to updating clients with current game info on every tick().
A great way to do this is by sending an xml doc string over the socket and then parsing. But we can do it however we want as long as it is clean.

Set up development environments and create initial project setup

Development Environment

We will be using eclipse oxygen, and the newest version of java sdk 9.0.1.

Initial Project Setup

Create the base folder with two packages, biowars.server and biowars.client

connect UI to controllers

get drag and drop working;

Create Virus abstract class and concrete virus types. Make a VirusFactory.

Add gold boost and population boost

Should we add these or just take em off the UI?

No comments in CureMktController.java

Make all properties private and return readonly properties to enforce proper object oriented encapsulation.

The properties' getters return the property. This is not good. We need to have all properties within the class have getters that return the read only property. To do this use ReadOnly versions of properties.

Add cure functionality

I though remove() on the virusApplied list would do the trick, but it's giving me a size of 0 at runtime, so no luck there

Rename ClientConnector and ClientModel.

ClientCommunicator and ServerCommunicator are more appropriate names.

Inconsistent use of new line between class declaration and initialization

public class SarsCure extends Cure{
	public SarsCure() {

vs

public class ColdCure extends Cure{
	
	public ColdCure() {

No newline in between instance variables and constructor in Inventory.java

Title is self-explanatory, class looks fantastic otherwise.