Giter Site home page Giter Site logo

Comments (6)

alexreg avatar alexreg commented on June 12, 2024

Sorry about the duplicate issues; the GitHub website was having issues yesterday!

from cloup.

janluke avatar janluke commented on June 12, 2024

If we rename the sorted attribute to, say, is_sorted, we need to bump the major version. I've already a 1.1 milestone, maybe we can just use type: ignore for now and reserve this for next 2.0 release.

from cloup.

janluke avatar janluke commented on June 12, 2024

Nah, let's just have 2.0 as next release.

from cloup.

janluke avatar janluke commented on June 12, 2024

In fact, we already renamed __constraints. Even if I consider it private API, someone could have used it anyway.

from cloup.

alexreg avatar alexreg commented on June 12, 2024

@janluke Yeah. I noticed that with __constraints -> __cloup_constraints__ (and good to see). Anyway, I agree that renaming the attribute to is_sorted is likely the best way to solve this conflict.

from cloup.

janluke avatar janluke commented on June 12, 2024

Do you want to open a PR for this?

from cloup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.